Convert constraints.f90 to Python#3630
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3630 +/- ##
==========================================
+ Coverage 37.01% 37.40% +0.39%
==========================================
Files 84 85 +1
Lines 21679 22250 +571
==========================================
+ Hits 8024 8323 +299
- Misses 13655 13927 +272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a7c88e6 to
22397e2
Compare
d7a917f to
1842ac5
Compare
ed63438 to
6317dfe
Compare
8d5fe79 to
b281443
Compare
406e808 to
dce76f6
Compare
jonmaddock
left a comment
There was a problem hiding this comment.
This is a great step, but I'm not totally convinced about the additional complexity of the decorator-based registration idea. What's the advantage of this approach?
jonmaddock
left a comment
There was a problem hiding this comment.
Thanks for explaining your approach, I'm happy with this now. Could you add docstrings to your new classes please, and find if there are any "adding a new constraint" docs which are now out of date. Could you deal with my minor "returning an array" comment, and lastly change cc and others to something more descriptive?
41697fb to
e0264d3
Compare
e0264d3 to
5c3ccfc
Compare
5c3ccfc to
f926ca7
Compare
* Convert constraint_eqns to Python * Write infrastructure to register Python constraints * Convert remaining equality constraints to Python * Convert upper limit constraints to Python * Convert lower limit constraints to Python * Convert init_constraint_variables to Python * Clarify documentation and variable names for Python constraint manager * Fix list formatting in docs
Description
Converts
constraint_equations.f90to Python.Notes
ccPROCESS/source/fortran/constraint_equations.f90
Lines 311 to 325 in 590cbb6
PROCESS/source/fortran/constraint_equations.f90
Lines 981 to 985 in 302cff7
>=because it follows the form of other equations with that sign.