Re-enable large tokamak (no f values)#3652
Merged
jonmaddock merged 1 commit intomainfrom May 22, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3652 +/- ##
==========================================
- Coverage 36.36% 36.12% -0.24%
==========================================
Files 88 88
Lines 22109 23046 +937
==========================================
+ Hits 8039 8326 +287
- Misses 14070 14720 +650 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Do you want to fix the error pointed out in #3574? |
jonmaddock
requested changes
May 14, 2025
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
Great that this happens to converge again, but could you make Michael's changes about the mutually exclusive iteration variables? I'm aware this was a pre-existing problem, but it might be partly responsible for the convergence trouble in the first place.
Collaborator
Author
|
#3662 will now fix the issue with large tokamak nof |
jonmaddock
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was disabled in #3619. Since then, something in the code has changed to cause the solver to take a different path and solve, although I'm not sure what (which is unsurprising since we don't know what caused it, although #3619 was put in just after #3565).