Skip to content

Re-enable large tokamak (no f values)#3652

Merged
jonmaddock merged 1 commit intomainfrom
reenable-lt-nof
May 22, 2025
Merged

Re-enable large tokamak (no f values)#3652
jonmaddock merged 1 commit intomainfrom
reenable-lt-nof

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn commented May 1, 2025

Was disabled in #3619. Since then, something in the code has changed to cause the solver to take a different path and solve, although I'm not sure what (which is unsurprising since we don't know what caused it, although #3619 was put in just after #3565).

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.12%. Comparing base (8341086) to head (bc36b0f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3652      +/-   ##
==========================================
- Coverage   36.36%   36.12%   -0.24%     
==========================================
  Files          88       88              
  Lines       22109    23046     +937     
==========================================
+ Hits         8039     8326     +287     
- Misses      14070    14720     +650     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn requested a review from jonmaddock May 1, 2025 15:03
@timothy-nunn timothy-nunn self-assigned this May 1, 2025
@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented May 2, 2025

Do you want to fix the error pointed out in #3574?
(dr_tf_wp and dr_tf_inboard are used as iteration variables simultaneously.)

Copy link
Copy Markdown
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that this happens to converge again, but could you make Michael's changes about the mutually exclusive iteration variables? I'm aware this was a pre-existing problem, but it might be partly responsible for the convergence trouble in the first place.

@timothy-nunn
Copy link
Copy Markdown
Collaborator Author

#3662 will now fix the issue with large tokamak nof

@timothy-nunn timothy-nunn requested a review from jonmaddock May 16, 2025 13:21
@jonmaddock jonmaddock merged commit 1c69494 into main May 22, 2025
18 checks passed
@jonmaddock jonmaddock deleted the reenable-lt-nof branch May 22, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants