🔄 Update reaction variables to new style

[chris-ashe]

Description

Since the restructuring of the fusion reactions done in #3345 came before the style guide the variable did not match. They have now been re-worded to fit the style guide.

Documentation enhancements:

• Added new naming conventions for fusion rates (fusrat_) and fusion rate densities (fusden_) in standards.md.
• Updated examples in documentation to reflect the new variable naming conventions, ensuring clarity and alignment with the codebase.

---

✨ New variables

p_beam_neutron_mw (See bugs section below)
fusrat_total
p_beam_dt_mw

---

🔄 Variable changes

Constriant

powfmax -> p_fusion_total_max_mw
ffuspow -> fp_fusion_total_max_mw

Total Powers

fusion_power -> p_fusion_total_mw
dt_power_total -> p_dt_total_mw
dt_power_plasma -> p_plasma_dt_mw
dd_power -> p_dd_total_mw
dhe3_power -> p_dhe3_total_mw

---

Rates

fusion_rate_density_total -> fusden_total
fusion_rate_density_plasma -> fusden_plasma
alpha_rate_density_total -> fusden_alpha_total
alpha_rate_density_plasma -> fusden_alpha_plasma

---

Alpha power

alpha_power_total -> p_alpha_total_mw
alpha_power_density_total -> pden_alpha_total_mw
alpha_power_plasma -> p_plasma_alpha_mw
alpha_power_density_plasma -> pden_plasma_alpha_mw
alpha_power_beams -> p_beam_alpha_mw
alpha_power_electron_density -> f_pden_alpha_electron_mw
alpha_power_ions_density -> f_pden_alpha_ions_mw

---

Neutron Power

neutron_power_total -> p_neutron_total_mw
neutron_power_density_total -> pden_neutron_total_mw
neutron_power_plasma -> p_plasma_neutron_mw
neutron_power_density_plasma -> pden_plasma_neutron_mw
neutron_power_beams -> p_beam_neutron_mw

---

Charged particle power

non_alpha_charged_power -> p_non_alpha_charged_mw
charged_particle_power -> p_charged_particle_mw
charged_power_density -> pden_charged_particle_mw

---

📝 Output changes

🐛 Bugs

The calculation of the total fusion power from the beam just used 5 as the multiplication power instead of using the proper ratio found in constants.f90

❌

physics_variables.p_dt_total_mw = (
                physics_variables.p_plasma_dt_mw
                + 5.0e0 * physics_variables.p_beam_alpha_mw
            )

✅

physics_variables.p_plasma_dt_mw
                + (1.0 / (1.0 - constants.dt_neutron_energy_fraction))
                * physics_variables.p_beam_alpha_mw
            )

---

The beam neutron power was being calculated in output (outplas()) instead of in the code. It was also using the wrong energy sharing fraction like for the alpha power above. This

❌

self.outfile,
            "Neutron power: beam-plasma (MW)",
            "(p_beam_neutron_mw)",
            physics_variables.p_beam_alpha_mw * 4.0e0,
            "OP ",

✅

physics_variables.p_beam_neutron_mw = physics_variables.p_beam_alpha_mw * (
                constants.dt_neutron_energy_fraction
                / (1 - constants.dt_neutron_energy_fraction)
            )

✅

self.outfile,
            "Neutron power: beam-plasma (MW)",
            "(p_beam_neutron_mw)",
            physics_variables.p_beam_neutron_mw,
            "OP ",

Checklist

I confirm that I have completed the following checks:

• My changes follow the PROCESS style guide
• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 36.30137% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.09%. Comparing base (b5572eb) to head (0bc8b5a).
⚠️ Report is 406 commits behind head on main.

Files with missing lines	Patch %	Lines
process/physics.py	36.14%	53 Missing ⚠️
process/fusion_reactions.py	54.16%	11 Missing ⚠️
process/stellarator.py	0.00%	11 Missing ⚠️
process/io/sankey_funcs.py	0.00%	8 Missing ⚠️
process/ife.py	0.00%	3 Missing ⚠️
process/evaluators.py	0.00%	1 Missing ⚠️
process/hcpb.py	50.00%	1 Missing ⚠️
process/objectives.py	0.00%	1 Missing ⚠️
process/physics_functions.py	0.00%	1 Missing ⚠️
process/power.py	0.00%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3656      +/-   ##
==========================================
- Coverage   36.36%   35.09%   -1.27%     
==========================================
  Files          88       88              
  Lines       22108    24951    +2843     
==========================================
+ Hits         8039     8757     +718     
- Misses      14069    16194    +2125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR updates reaction variable names and related constants for fusion power calculations to conform with the new PROCESS style guide. Key changes include renaming variables (e.g. from fusion_power to p_fusion_total_mw and ffuspow to fp_fusion_total_max_mw), updating associated documentation examples, and modifying input data files to reflect the new naming conventions.

Reviewed Changes

Copilot reviewed 78 out of 78 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
process/costs_2015.py	Updated cost scaling to use the new fusion power variable.
process/costs.py	Changed fusion power references for cost calculations to the new variable names.
process/availability.py	Revised fusion power scaling in availability calculations in line with the new style.
examples/scan.ipynb, examples/plot_solutions.ipynb	Updated command-line and in-notebook references for fusion power variables.
examples/data/*.DAT	Renamed fusion power variables in input data to match the updated naming convention.
documentation/proc-pages/physics-models/*	Updated documentation to describe the new variable names and scaling factors.
documentation/proc-pages/development/*	Adjusted standards and constraint equation documentation along with the variable renames.

Comments suppressed due to low confidence (1)

documentation/proc-pages/development/add-vars.md:256

• Verify that the updated scaling factor expression correctly reflects the intended calculation. Using p_fusion_total_max_mw in both the numerator and denominator may simplify unexpectedly, so please ensure this is the desired behavior.

args%cc =  1.0D0 - fp_fusion_total_max_mw * p_fusion_total_max_mw/p_fusion_total_mw

[j-a-foster]

Happy with the variable name changes - all in line with the standard guide.

[clmould]

Looks good to me!