Skip to content

🧲 TF plot_proc strand turn plotting#3807

Merged
timothy-nunn merged 17 commits intomainfrom
tf_plot_proc_strand_turn_plotting
Oct 21, 2025
Merged

🧲 TF plot_proc strand turn plotting#3807
timothy-nunn merged 17 commits intomainfrom
tf_plot_proc_strand_turn_plotting

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

@chris-ashe chris-ashe commented Aug 27, 2025

This pull request introduces new variables and calculations related to the superconducting cables used in the Toroidal Field (TF) coil system. The main focus is on tracking the number, diameter, and total length of superconducting cables, as well as integrating these properties into the initialization, calculation, and output routines. These changes improve the model's ability to represent cable-in-conduit conductor (CICC) properties and provide more detailed outputs for analysis.

✨ New additions

  • n_tf_turn_superconducting_cables
  • len_tf_coil_superconductor
  • len_tf_superconductor_total

Functions

  • calculate_cable_in_conduit_strand_count()
  • calculate_cable_in_conduit_superconductor_length()

Calculation Routines

  • Implemented calculate_cable_in_conduit_strand_count and calculate_cable_in_conduit_superconductor_length methods in superconducting_tf_coil.py to compute the number of strands and total cable length based on geometric and physical parameters. These are used to update the new variables during TF coil geometry calculation.
image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe self-assigned this Aug 27, 2025
@chris-ashe chris-ashe added Input/Output Files Issues related to the input and output data files TF Coil Toroidal field coil labels Aug 27, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 11.29032% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.06%. Comparing base (62a64c4) to head (04fa6a2).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
process/io/plot_proc.py 2.02% 97 Missing ⚠️
process/superconducting_tf_coil.py 18.18% 9 Missing ⚠️
process/tf_coil.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3807      +/-   ##
==========================================
- Coverage   46.19%   46.06%   -0.14%     
==========================================
  Files         123      123              
  Lines       28358    28465     +107     
==========================================
+ Hits        13100    13112      +12     
- Misses      15258    15353      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe force-pushed the tf_plot_proc_strand_turn_plotting branch from 8e814b6 to 0bbdef1 Compare August 27, 2025 14:20
@chris-ashe chris-ashe changed the title Tf plot proc strand turn plotting 🧲 TF plot_proc strand turn plotting Aug 27, 2025
@chris-ashe chris-ashe force-pushed the tf_plot_proc_strand_turn_plotting branch 6 times, most recently from 0aa6023 to c53b2a0 Compare September 3, 2025 15:00
@chris-ashe chris-ashe force-pushed the tf_plot_proc_strand_turn_plotting branch from c53b2a0 to a6eb05a Compare October 3, 2025 17:44
@chris-ashe chris-ashe marked this pull request as ready for review October 9, 2025 12:57
@chris-ashe chris-ashe requested a review from j-a-foster October 13, 2025 12:24
@chris-ashe chris-ashe force-pushed the tf_plot_proc_strand_turn_plotting branch from 56c2122 to f9c6f07 Compare October 13, 2025 12:46
@chris-ashe chris-ashe requested a review from clmould October 15, 2025 08:34
Copy link
Copy Markdown
Collaborator

@clmould clmould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me

Comment thread process/superconducting_tf_coil.py Outdated
Comment thread process/tf_coil.py
@chris-ashe chris-ashe force-pushed the tf_plot_proc_strand_turn_plotting branch 3 times, most recently from 48758c6 to 7d3191d Compare October 17, 2025 10:28
@clmould clmould self-requested a review October 20, 2025 10:26
@chris-ashe chris-ashe force-pushed the tf_plot_proc_strand_turn_plotting branch 2 times, most recently from 6c33fbe to ce86eeb Compare October 21, 2025 08:43
@timothy-nunn timothy-nunn self-requested a review October 21, 2025 09:42
…eter and void fraction, and calculate inner superconductor radius based on copper area fraction
…r TF coils and update cable-in-conduit parameters
@chris-ashe chris-ashe force-pushed the tf_plot_proc_strand_turn_plotting branch from da75600 to 04fa6a2 Compare October 21, 2025 10:08
Copy link
Copy Markdown
Collaborator

@j-a-foster j-a-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes.

@timothy-nunn timothy-nunn merged commit 45ac7e9 into main Oct 21, 2025
21 of 27 checks passed
@timothy-nunn timothy-nunn deleted the tf_plot_proc_strand_turn_plotting branch October 21, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Input/Output Files Issues related to the input and output data files New Variables TF Coil Toroidal field coil

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants