🧲 TF plot_proc strand turn plotting#3807
Merged
timothy-nunn merged 17 commits intomainfrom Oct 21, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3807 +/- ##
==========================================
- Coverage 46.19% 46.06% -0.14%
==========================================
Files 123 123
Lines 28358 28465 +107
==========================================
+ Hits 13100 13112 +12
- Misses 15258 15353 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8e814b6 to
0bbdef1
Compare
plot_proc strand turn plotting
0aa6023 to
c53b2a0
Compare
c53b2a0 to
a6eb05a
Compare
56c2122 to
f9c6f07
Compare
clmould
reviewed
Oct 15, 2025
Collaborator
clmould
left a comment
There was a problem hiding this comment.
The logic looks good to me
timothy-nunn
requested changes
Oct 15, 2025
48758c6 to
7d3191d
Compare
6c33fbe to
ce86eeb
Compare
…and integrate into TF coil plotting
…rease max attempts for improved packing efficiency
…le-in-conduit conductors
…culation into TF coil output
…ation and enhance strand packing logic
…eter and void fraction, and calculate inner superconductor radius based on copper area fraction
…onfigurations for improved visualization
… into main plotting routine
…r TF coils and update cable-in-conduit parameters
…d update initialization function
…ils and update initialization function
… outputs for superconductor lengths
…fraction and update related parameters
…subplot assignments
da75600 to
04fa6a2
Compare
timothy-nunn
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new variables and calculations related to the superconducting cables used in the Toroidal Field (TF) coil system. The main focus is on tracking the number, diameter, and total length of superconducting cables, as well as integrating these properties into the initialization, calculation, and output routines. These changes improve the model's ability to represent cable-in-conduit conductor (CICC) properties and provide more detailed outputs for analysis.
✨ New additions
n_tf_turn_superconducting_cableslen_tf_coil_superconductorlen_tf_superconductor_totalFunctions
calculate_cable_in_conduit_strand_count()calculate_cable_in_conduit_superconductor_length()Calculation Routines
calculate_cable_in_conduit_strand_countandcalculate_cable_in_conduit_superconductor_lengthmethods insuperconducting_tf_coil.pyto compute the number of strands and total cable length based on geometric and physical parameters. These are used to update the new variables during TF coil geometry calculation.Checklist
I confirm that I have completed the following checks: