Skip to content

Convert file output and constants to Python#3811

Merged
timothy-nunn merged 4 commits intomainfrom
convert-remaining-core
Sep 8, 2025
Merged

Convert file output and constants to Python#3811
timothy-nunn merged 4 commits intomainfrom
convert-remaining-core

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn commented Aug 28, 2025

To avoid merge conflicts and because so little remains, this PR will convert the remaining core (output file handling) to Python. It will also convert global_variables and constants to Python, because these depended on the output conversion.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 78.71854% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.87%. Comparing base (f71d71b) to head (be3842e).

Files with missing lines Patch % Lines
process/scan.py 4.54% 42 Missing ⚠️
process/process_output.py 75.36% 17 Missing ⚠️
process/final.py 25.00% 9 Missing ⚠️
process/caller.py 20.00% 4 Missing ⚠️
process/fusion_reactions.py 55.55% 4 Missing ⚠️
process/init.py 75.00% 3 Missing ⚠️
process/pfcoil.py 62.50% 3 Missing ⚠️
process/physics.py 75.00% 3 Missing ⚠️
process/tf_coil.py 78.57% 3 Missing ⚠️
process/current_drive.py 77.77% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3811      +/-   ##
==========================================
+ Coverage   46.49%   46.87%   +0.38%     
==========================================
  Files         120      122       +2     
  Lines       27308    27515     +207     
==========================================
+ Hits        12697    12899     +202     
- Misses      14611    14616       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn force-pushed the convert-remaining-core branch from 38471b2 to a596c9e Compare August 29, 2025 08:10
@timothy-nunn timothy-nunn self-assigned this Aug 29, 2025
@timothy-nunn timothy-nunn changed the title Convert remaining core to Python Convert file output and constants to Python Aug 29, 2025
@timothy-nunn timothy-nunn marked this pull request as ready for review August 29, 2025 10:22
@timothy-nunn timothy-nunn force-pushed the convert-remaining-core branch 2 times, most recently from 6942a90 to 87df877 Compare August 29, 2025 12:05
@timothy-nunn timothy-nunn force-pushed the convert-remaining-core branch from 87df877 to be3842e Compare September 8, 2025 10:34
@timothy-nunn timothy-nunn merged commit 7ff9e56 into main Sep 8, 2025
20 checks passed
@timothy-nunn timothy-nunn deleted the convert-remaining-core branch September 8, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert global_variables.f90 to Python Finish init_module.f90 conversion Convert constants.f90 to Python Convert output.f90 to Python

5 participants