Fusion reaction profile plot_proc#3827
Merged
timothy-nunn merged 12 commits intomainfrom Sep 23, 2025
Merged
Conversation
396f3b1 to
1a3216a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3827 +/- ##
==========================================
- Coverage 46.67% 44.77% -1.91%
==========================================
Files 122 122
Lines 27804 30481 +2677
==========================================
+ Hits 12977 13647 +670
- Misses 14827 16834 +2007 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
77f6a09 to
1a3216a
Compare
…lasma_dd_triton_profile
…lasma_dd_helion_profile
…st subplot configurations
…sity information for D-T, D-D, D-3He, alpha, and neutron reactions
201e26b to
b06daf7
Compare
b06daf7 to
3d61ceb
Compare
jonmaddock
approved these changes
Sep 22, 2025
|
|
||
| plot_33 = fig17.add_subplot(111, aspect="equal") | ||
| plot_main_power_flow(plot_33, m_file_data, scan, fig17) | ||
| plot_33 = fig18.add_subplot(111, aspect="equal") |
Contributor
There was a problem hiding this comment.
I don't like all these hardcoded numbers that need moving around. Fine here, but can you make an issue to turn this into a list?
Contributor
|
Seems like regression tests are failing due to request limits. Can you re-run or talk to Tim about how we can work around these? |
j-a-foster
approved these changes
Sep 23, 2025
Collaborator
j-a-foster
left a comment
There was a problem hiding this comment.
Happy with the changes.
grmtrkngtn
pushed a commit
that referenced
this pull request
Oct 10, 2025
* ❇️ Add fusion reaction rate profile variable for D-T plasma, fusrat_plasma_dt_profile * Add fusion rate profile plotting and data handling for D-T plasma * ❇️ Add fusion reaction rate profile variable for D-T plasma, fusrat_plasma_dd_triton_profile * ❇️ Add fusion reaction rate profile variable for D-D plasma, fusrat_plasma_dd_helion_profile * Add D-D and D-T fusion rate profile calculations and plotting * ❇️ Add D-3He fusion reaction rate profile variable and update initialization * ❇️ Add D-3He fusion reaction rate profile calculations and plotting * ❇️ Update plotting functions to include fusion rate profiles and adjust subplot configurations * Enhance fusion rate profile plotting by adding detailed power and density information for D-T, D-D, D-3He, alpha, and neutron reactions * Refactor constants usage in plotting and physics modules for consistency * ♻️ Update fusion reaction calculations to use density profile * Add total fusion rate profile calculation and plotting to fusion rate profiles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces fusion reaction rate profile tracking for multiple fusion channels and adds a new plotting function to visualize these profiles and their corresponding fusion power. The changes span data structure updates, calculation logic, and plotting enhancements, resulting in improved diagnostics and visualization of fusion rates and power across the plasma radius.
❇️ New variables
fusrat_plasma_dt_profilefusrat_plasma_dd_helion_profilefusrat_plasma_dhe3_profilefusrat_plasma_dd_triton_profile🎨 New output
Fusion Reaction Rate Profile Tracking and Visualization
Data Structure and Initialization:
physics_variables.pyto store plasma fusion reaction rate profiles for D-T, D-D (triton and helion branches), and D-3He channels, along with their initialization ininit_physics_variables()and default values.Fusion Rate Profile Calculation:
Plotting Enhancements:
plot_fusion_rate_profiles()inplot_proc.pyto visualize fusion rate and fusion power profiles for all channels, with detailed annotations and legends for diagnostics.Checklist
I confirm that I have completed the following checks: