Exempt np.linalg.solve call from nopython mode#3856
Merged
timothy-nunn merged 1 commit intomainfrom Sep 25, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3856 +/- ##
==========================================
- Coverage 46.67% 43.06% -3.62%
==========================================
Files 122 123 +1
Lines 27806 33237 +5431
==========================================
+ Hits 12978 14312 +1334
- Misses 14828 18925 +4097 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
jonmaddock
requested changes
Sep 25, 2025
Contributor
jonmaddock
left a comment
There was a problem hiding this comment.
Brilliant, but needs a comment about why this is required.
5ce880e to
62487ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @nickodell for this great suggestion. This stops numba from compiling the
linalg.solveagainst SciPy's solvers and uses numpy's linear algebra in normal (non-Numba) mode. I also took this opportunity to remove theasfortranarraybecause that is not necessary (and possibly has never been)