Fix full-output for evaluation MFiles#3867
Merged
timothy-nunn merged 2 commits intomainfrom Nov 4, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3867 +/- ##
==========================================
- Coverage 46.22% 46.22% -0.01%
==========================================
Files 123 123
Lines 28564 28569 +5
==========================================
+ Hits 13203 13205 +2
- Misses 15361 15364 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
788cd2a to
8844136
Compare
chris-ashe
reviewed
Oct 30, 2025
Collaborator
chris-ashe
left a comment
There was a problem hiding this comment.
Just cheeked the provided output pdf. Why is the solver iterations still a float?
8844136 to
c3ad5b9
Compare
Collaborator
Author
Fixed, here are the new PDFs |
chris-ashe
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--full-outputnow works on evaluation input files e.g. large_tokamak_eval.MFILE.DATSUMMARY.pdfHere I have also fixed some strings not wrapping after 60 characters and interesting plots on the first page. Some information about the evaluation runs was also wrong because it is not present in the MFile and was returning a default
0.I have confirmed that the large tokamak still runs and produces an appropriate output: large_tokamak.MFILE.DATSUMMARY.pdf