🐛 Update WP cross section area label to reflect total steel area …#3883
🐛 Update WP cross section area label to reflect total steel area …#3883timothy-nunn merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3883 +/- ##
=======================================
Coverage 46.45% 46.45%
=======================================
Files 123 123
Lines 28050 28050
=======================================
Hits 13030 13030
Misses 15020 15020 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
left a comment
There was a problem hiding this comment.
Does the description of the variable also need to be updated to agree with the output title?
PROCESS/process/data_structure/tfcoil_variables.py
Lines 63 to 64 in 50cfc49
Some of the other _steel variables also seem to have generic/ no steel-specific descriptions
cf52d34 to
a57a71f
Compare
Have re-done that variable description and one other |
This pull request makes a small update to the output labeling in the
outtfmethod oftf_coil.py. The label for a particular variable has been clarified to better reflect its meaning, and the corresponding variable reference has been updated to match.🐛 Bug
a_tf_wp_no_insulationtoa_tf_wp_steelin theouttfmethod oftf_coil.py…in TF coil outputDescription
Checklist
I confirm that I have completed the following checks: