-
Notifications
You must be signed in to change notification settings - Fork 18
♻️ Refactor CroCo routines and variables #3891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
19b7c1d
🔄 - Rename variable 'croco_od' to 'dia_croco_strand' for improved cla…
chris-ashe bb25644
🔄 - Rename 'croco_thick' to 'dx_croco_strand_copper' for improved cla…
chris-ashe 9eb4e56
🔄 Rename 'rebco_thickness' to 'dx_hts_tape_rebco' for improved clarit…
chris-ashe f7dae9b
🔄 Rename 'copper_thick' to 'dx_hts_tape_copper' for improved clarity …
chris-ashe fd15dee
🔄 Rename 'hastelloy_thickness' to 'dx_hts_tape_hastelloy' for improve…
chris-ashe 8a867b2
🔄 Rename 'stack_thickness' to 'dx_croco_strand_tape_stack' for improv…
chris-ashe 34d44c5
🔄 Rename 'tape_thickness' to 'dx_hts_tape_total' for improved clarity…
chris-ashe 6c360f7
🔄 Rename 'tape_width' to 'dr_hts_tape' for improved clarity and consi…
chris-ashe ece23f1
🔄 Rename 'tapes' to 'n_croco_strand_hts_tapes' for improved clarity a…
chris-ashe fd81380
🔄 Rename 'rebco_area' to 'a_croco_strand_hts_tapes' for improved clar…
chris-ashe 74d609a
🔄 Rename 'hastelloy_area' to 'a_croco_strand_hastelloy' for improved …
chris-ashe 3fcb686
🔄 Rename 'solder_area' to 'a_croco_strand_solder' and update referenc…
chris-ashe 5779a8f
🔄 Rename 'croco_id' to 'dia_croco_strand_tape_region' for improved cl…
chris-ashe 1a75269
:fire: Remove unused variable 'croco_area' and its references for cod…
chris-ashe b4bf60b
🔄 Rename 'copper_area' to 'a_croco_strand_copper_total' and update re…
chris-ashe 4446a13
:sparkle: Add 'calculate_croco_cable_geometry' function to compute ge…
chris-ashe d6eea32
:sparkle: Add 'a_croco_strand' variable to store total area of CroCo …
chris-ashe 19554cc
:memo: Create docs page
chris-ashe c28f6d6
🔄 Rename 'a_croco_strand_hts_tapes' to 'a_croco_strand_rebco' and upd…
chris-ashe ea5bbd8
:sparkle: Add 'plot_corc_cable_geometry' function to visualize CroCo …
chris-ashe f33df00
:sparkle: Update obsolete variable mappings in 'obsolete_vars.py' for…
chris-ashe 5366813
:sparkle: Remove unused parameter 'dr_hts_tape' from 'calculate_croco…
chris-ashe 2eb1c55
Incorporate new croco strand calc into old function
chris-ashe 69ab458
Review request changes
chris-ashe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.