Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3901 +/- ##
==========================================
- Coverage 46.38% 46.15% -0.24%
==========================================
Files 123 123
Lines 28162 28841 +679
==========================================
+ Hits 13064 13311 +247
- Misses 15098 15530 +432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clmould
requested changes
Oct 13, 2025
Collaborator
clmould
left a comment
There was a problem hiding this comment.
Looks good, only a couple minor changes then will merge :)
clmould
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DICT_ICC_FULLwas not being properly populated because it was using iteration variable (IXC) information... I have rewritten theget_constraint_equationsfunction to use theConstraintManagerobject directly to verify a constraint number is valid.DICT_ICC_FULLis therefore no longer used and I have removed it.