Skip to content

Rewriting an indat changes the results#3901

Merged
clmould merged 4 commits intomainfrom
3899-bug-rewriting-an-indat-changes-the-results
Oct 13, 2025
Merged

Rewriting an indat changes the results#3901
clmould merged 4 commits intomainfrom
3899-bug-rewriting-an-indat-changes-the-results

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn commented Oct 10, 2025

The DICT_ICC_FULL was not being properly populated because it was using iteration variable (IXC) information... I have rewritten the get_constraint_equations function to use the ConstraintManager object directly to verify a constraint number is valid. DICT_ICC_FULL is therefore no longer used and I have removed it.

@timothy-nunn timothy-nunn linked an issue Oct 10, 2025 that may be closed by this pull request
@timothy-nunn timothy-nunn requested a review from clmould October 10, 2025 14:42
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.15%. Comparing base (c9a56cd) to head (5859d53).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
process/io/in_dat.py 36.36% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3901      +/-   ##
==========================================
- Coverage   46.38%   46.15%   -0.24%     
==========================================
  Files         123      123              
  Lines       28162    28841     +679     
==========================================
+ Hits        13064    13311     +247     
- Misses      15098    15530     +432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn self-assigned this Oct 10, 2025
Copy link
Copy Markdown
Collaborator

@clmould clmould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a couple minor changes then will merge :)

Comment thread process/io/in_dat.py Outdated
Comment thread process/io/in_dat.py Outdated
@timothy-nunn timothy-nunn requested a review from clmould October 13, 2025 12:31
@clmould clmould merged commit bf62c3f into main Oct 13, 2025
18 checks passed
@timothy-nunn timothy-nunn deleted the 3899-bug-rewriting-an-indat-changes-the-results branch October 13, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Rewriting an IN.DAT changes the results

3 participants