🐛 Fix error in volume averaged thermal plasma pressure to be prof…#3938
Merged
timothy-nunn merged 3 commits intomainfrom Oct 28, 2025
Merged
🐛 Fix error in volume averaged thermal plasma pressure to be prof…#3938timothy-nunn merged 3 commits intomainfrom
timothy-nunn merged 3 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3938 +/- ##
==========================================
- Coverage 46.19% 46.18% -0.01%
==========================================
Files 123 123
Lines 28358 28362 +4
==========================================
Hits 13100 13100
- Misses 15258 15262 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
21a0f2f to
3ba98ac
Compare
fda8dc3 to
ee753f6
Compare
…tures and clarify assumptions for parabolic profiles
ee753f6 to
2d4bba9
Compare
…essure profiles plot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates both the documentation and implementation for plasma pressure and temperature profile calculations, with a focus on clarifying the distinction between central and volume-averaged quantities and ensuring that density-weighted temperatures are used consistently in calculations. The changes improve scientific clarity, correct some formulae, and align the code with the updated documentation.
Documentation improvements and clarifications:
f_temp_plasma_electron_density_vol_avginstead of the ambiguouspcoef.Code consistency and scientific accuracy:
process/plasma_profiles.pyto use the correct energy conversion constant and clarified the formula.These changes ensure that the documentation and code are aligned, and that the scientific calculations reflect best practices for plasma profile modeling.…ile independent
Description
Checklist
I confirm that I have completed the following checks: