Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3941 +/- ##
==========================================
- Coverage 46.06% 46.06% -0.01%
==========================================
Files 123 123
Lines 28467 28470 +3
==========================================
Hits 13114 13114
- Misses 15353 15356 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fceaabe to
9becc4e
Compare
c419ecd to
1473604
Compare
clmould
reviewed
Oct 23, 2025
| marker="o", | ||
| color="blue", | ||
| markersize=5, | ||
| label="Vertical centre of coil", |
Collaborator
Collaborator
Author
There was a problem hiding this comment.
Just realised the legend is using the defined labels array to show the arc points. When I add the coil masses and areas section beside the plot in a (121) config I will put it into a real text box
…n TF coil vertical offset calculations
…set` for clarity in TF coil vertical offset calculations
…ty in TF coil thickness ratio calculations
…ard` in input validator
…arity in TF coil vertical offset calculations across multiple data files
8b3a084 to
6df243e
Compare
6df243e to
30f200a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request standardizes and clarifies variable naming related to the vertical and radial build of the toroidal field (TF) coil, updates documentation and input handling, and improves visualization in the plotting routines. The most significant changes are the renaming of key variables for consistency and clarity, updates to documentation and input files, and enhancements to the coil structure plot.
🔄 Variable renaming
tfoffsettodz_tf_plasma_centre_offsettfootfitof_dr_tf_outboard_inboardfor the outboard/inboard TF coil thickness ratio,Documentation and input/output updates:
tf-coil.mdto reflect new variable names and descriptions for user input parameters.Plotting improvements:
plot_tf_coil_structureinplot_proc.pyby adding markers for the top and vertical center of the coil, a horizontal line at the coil center, and a label showing the offset between the coil center and plasma center for better visualization and clarity.Checklist
I confirm that I have completed the following checks: