♻️ Refactor Availability module part1#3942
Conversation
7437ff6 to
bed7977
Compare
bed7977 to
8b1af38
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3942 +/- ##
==========================================
- Coverage 46.03% 45.98% -0.05%
==========================================
Files 123 123
Lines 28970 29074 +104
==========================================
+ Hits 13335 13371 +36
- Misses 15635 15703 +68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
26d801a to
9479318
Compare
kj5248
left a comment
There was a problem hiding this comment.
Just a couple more missed
kj5248
left a comment
There was a problem hiding this comment.
All seems good now just needs to pass tests
bd6c31a to
d89a49c
Compare
kj5248
left a comment
There was a problem hiding this comment.
I have re-approved this. Good catch on i_plant_availabilityt_availability, I had only checked for the old still being around in the big mfiles
kj5248
left a comment
There was a problem hiding this comment.
Just noticed this on double check
97fd85c to
d89a49c
Compare
…nput files, and code for consistency and clarity.
…ding section headers and improving formatting for clarity.
…documentation, code, and input files
…ode, documentation, and input files
…stency across code and tests
…e data files and code modules to improve clarity and consistency.
…bility.py` and `cost_variables.py` to improve clarity and consistency.
…ta files, test files, and tracking data to maintain consistency and clarity.
…ency and clarity; updated related references in code and tests.
…i_plant_availability' for consistency across multiple data files.
f19288d to
1646e98
Compare
kj5248
left a comment
There was a problem hiding this comment.
Two got missed. Also noticed a file disappeared from examples: examples/data/scan_MFILE.DAT? Not sure if that is intentional.
1646e98 to
d5ddab8
Compare
d5ddab8 to
ad62538
Compare
This pull request updates the naming conventions and documentation for the plant availability models and related variables to improve clarity and consistency across the codebase, documentation, and example data files. The changes also introduce more detailed documentation for each availability model and its associated calculations.
🔄 Renames
iavail->i_plant_availabilitytbktrepl->t_blkt_replace_yrstdivrepl->t_div_replace_yrst_operation->t_plant_operational_total_yrscfactr->f_t_plant_availablecdrlife->life_hcd_fpytlife->life_plantdivlife->life_div_fpydivlife_cal->life_divDocumentation improvements and variable renaming:
iavailtoi_plant_availability, and the overall plant availability factor fromcfactrtof_t_plant_availablethroughoutdocumentation/eng-models/plant-availability.md,documentation/io/python-lib-guide.md, and all example data files. [1] [2] [3] [4] [5] [6]divlifetolife_div_fpyv_fpy,cdrlifetolife_hcd_fpy,tlifetolife_plant, andcfactrtof_t_plant_available. [1] [2] [3] [4] [5] [6] [7] [8]plant-availability.mdto describe the Taylor-Ward, Morris, and Spherical Tokamak (ST) models, including their input parameters, calculation methods, and relevant equations. New sections detail planned and unplanned unavailability calculations for various subsystems. [1] [2] [3]These changes ensure consistent naming, clearer documentation, and easier maintenance and extension of the plant availability models.## Description
Checklist
I confirm that I have completed the following checks: