Skip to content

Add new obsolete variable mappings for pulse plant parameters#3951

Merged
clmould merged 3 commits intomainfrom
time_obsolete_variables
Oct 23, 2025
Merged

Add new obsolete variable mappings for pulse plant parameters#3951
clmould merged 3 commits intomainfrom
time_obsolete_variables

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

@chris-ashe chris-ashe commented Oct 23, 2025

This pull request adds new mappings to the obsolete variable translation dictionary in obsolete_vars.py, helping to map several time-related legacy variable names to their updated equivalents.

New obsolete variable mappings:

  • Added mappings for time-related variables, including t_fusion_ramp, t_current_ramp_up, t_current_ramp_down, t_between_pulses, t_precharge, and t_burn, translating them to their new standardized names in the dictionary.## Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe requested a review from clmould October 23, 2025 15:48
@chris-ashe chris-ashe self-assigned this Oct 23, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.06%. Comparing base (0519605) to head (160bbec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3951   +/-   ##
=======================================
  Coverage   46.06%   46.06%           
=======================================
  Files         123      123           
  Lines       28467    28467           
=======================================
  Hits        13114    13114           
  Misses      15353    15353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread process/io/obsolete_vars.py Outdated
Comment thread process/io/obsolete_vars.py Outdated
chris-ashe and others added 2 commits October 23, 2025 16:57
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
@clmould clmould merged commit 4818b3b into main Oct 23, 2025
18 checks passed
@clmould clmould deleted the time_obsolete_variables branch October 23, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants