🐛 TF non integer turn plot_proc bugs#3953
Merged
chris-ashe merged 3 commits intomainfrom Oct 24, 2025
Merged
Conversation
plot_proc bugs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3953 +/- ##
==========================================
- Coverage 46.06% 46.06% -0.01%
==========================================
Files 123 123
Lines 28467 28478 +11
==========================================
+ Hits 13114 13118 +4
- Misses 15353 15360 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements and corrections to the plotting logic and labeling in the
_pack_strands_rectangular_with_obstaclesfunction inprocess/io/plot_proc.py. The main focus is on improving the accuracy of geometric calculations, clarifying axis labels, and enhancing the information displayed in plot annotations.Key changes include:
Geometric and Calculation Corrections:
turn_widthfor both dimensions; now usesturn_heightfor the vertical dimension._pack_strands_rectangular_with_obstaclesfunction to use explicit keyword arguments, improving clarity and reducing risk of errors.Plot Annotation and Labeling Improvements:
"X [m]"and"Y [m]"to"r [m]"and"x [m]"for more accurate physical representation.Checklist
I confirm that I have completed the following checks: