Skip to content

🐛 TF non integer turn plot_proc bugs#3953

Merged
chris-ashe merged 3 commits intomainfrom
tf_non_integer_turn_plot_proc_bugs
Oct 24, 2025
Merged

🐛 TF non integer turn plot_proc bugs#3953
chris-ashe merged 3 commits intomainfrom
tf_non_integer_turn_plot_proc_bugs

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

@chris-ashe chris-ashe commented Oct 24, 2025

This pull request makes several improvements and corrections to the plotting logic and labeling in the _pack_strands_rectangular_with_obstacles function in process/io/plot_proc.py. The main focus is on improving the accuracy of geometric calculations, clarifying axis labels, and enhancing the information displayed in plot annotations.

Key changes include:

Geometric and Calculation Corrections:

  • Fixed a bug where the width and height of the cable space rectangle were incorrectly calculated using turn_width for both dimensions; now uses turn_height for the vertical dimension.
  • Updated the parameters passed to the _pack_strands_rectangular_with_obstacles function to use explicit keyword arguments, improving clarity and reducing risk of errors.

Plot Annotation and Labeling Improvements:

  • Changed axis labels from "X [m]" and "Y [m]" to "r [m]" and "x [m]" for more accurate physical representation.
  • Improved the formatting and content of cable space and turn information in plot text annotations, including clearer variable names, better formatting, and more precise placement in the figure.
image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe requested a review from ajpearcey October 24, 2025 09:23
@chris-ashe chris-ashe self-assigned this Oct 24, 2025
@chris-ashe chris-ashe added the Bug label Oct 24, 2025
@chris-ashe chris-ashe changed the title Tf non integer turn plot proc bugs 🐛 TF non integer turn plot_proc bugs Oct 24, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.06%. Comparing base (0519605) to head (e22e8af).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/io/plot_proc.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3953      +/-   ##
==========================================
- Coverage   46.06%   46.06%   -0.01%     
==========================================
  Files         123      123              
  Lines       28467    28478      +11     
==========================================
+ Hits        13114    13118       +4     
- Misses      15353    15360       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@ajpearcey ajpearcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chris-ashe chris-ashe merged commit 12bf604 into main Oct 24, 2025
18 checks passed
@chris-ashe chris-ashe deleted the tf_non_integer_turn_plot_proc_bugs branch October 24, 2025 09:50
@je-cook je-cook added the Bug Something isnt working label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isnt working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants