3958 hcd efficiencies missing as inputs#3961
Merged
timothy-nunn merged 2 commits intomainfrom Oct 30, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3961 +/- ##
==========================================
+ Coverage 45.98% 46.24% +0.25%
==========================================
Files 123 123
Lines 28550 28550
==========================================
+ Hits 13129 13203 +74
+ Misses 15421 15347 -74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chris-ashe
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds the wall plug efficiencies for the EBW and ICRH HCD models as inputs and changed their default values to avoid a divide by zero error when running them.
A bug was also found in the EBW efficiency model where the wrong units were used for electron density. This resulted in the efficiency always being zero. This has been corrected and tests have been added for the HCD efficiency models that weren't tested.
Checklist
I confirm that I have completed the following checks: