Skip to content

3958 hcd efficiencies missing as inputs#3961

Merged
timothy-nunn merged 2 commits intomainfrom
3958-hcd-efficiencies-missing-as-inputs
Oct 30, 2025
Merged

3958 hcd efficiencies missing as inputs#3961
timothy-nunn merged 2 commits intomainfrom
3958-hcd-efficiencies-missing-as-inputs

Conversation

@j-a-foster
Copy link
Copy Markdown
Collaborator

@j-a-foster j-a-foster commented Oct 29, 2025

Description

This adds the wall plug efficiencies for the EBW and ICRH HCD models as inputs and changed their default values to avoid a divide by zero error when running them.

A bug was also found in the EBW efficiency model where the wrong units were used for electron density. This resulted in the efficiency always being zero. This has been corrected and tests have been added for the HCD efficiency models that weren't tested.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster j-a-foster requested a review from chris-ashe October 29, 2025 15:50
@j-a-foster j-a-foster self-assigned this Oct 29, 2025
@j-a-foster j-a-foster added the Bug label Oct 29, 2025
@j-a-foster j-a-foster linked an issue Oct 29, 2025 that may be closed by this pull request
@j-a-foster j-a-foster added Testing HCD Relating to heating and current drive systems labels Oct 29, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.24%. Comparing base (633a49e) to head (44173d2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3961      +/-   ##
==========================================
+ Coverage   45.98%   46.24%   +0.25%     
==========================================
  Files         123      123              
  Lines       28550    28550              
==========================================
+ Hits        13129    13203      +74     
+ Misses      15421    15347      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn merged commit 88cc783 into main Oct 30, 2025
14 of 18 checks passed
@timothy-nunn timothy-nunn deleted the 3958-hcd-efficiencies-missing-as-inputs branch October 30, 2025 09:45
@je-cook je-cook added the Bug Something isnt working label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isnt working HCD Relating to heating and current drive systems Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HCD efficiencies missing as inputs

5 participants