Skip to content

Write NaN to other H-factor table if calculation fails#3965

Merged
timothy-nunn merged 1 commit intomainfrom
other-hfact-error
Oct 30, 2025
Merged

Write NaN to other H-factor table if calculation fails#3965
timothy-nunn merged 1 commit intomainfrom
other-hfact-error

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

Fixes one of the errors in #3957. This error occurs when calculating comparison H-factors for a table in the OUT.DAT. It does not matter if these values are not in the OUT.DAT and so this PR sets it as a NaN if the calculation fails.

@timothy-nunn timothy-nunn self-assigned this Oct 30, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.24%. Comparing base (88cc783) to head (61643fb).
⚠️ Report is 125 commits behind head on main.

Files with missing lines Patch % Lines
process/physics.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3965      +/-   ##
==========================================
- Coverage   46.24%   46.24%   -0.01%     
==========================================
  Files         123      123              
  Lines       28550    28553       +3     
==========================================
  Hits        13203    13203              
- Misses      15347    15350       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn merged commit a238c01 into main Oct 30, 2025
18 checks passed
@timothy-nunn timothy-nunn deleted the other-hfact-error branch October 30, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants