Skip to content

Use Clarabel instead of OSQP to solve QPP in VMCON#3971

Merged
timothy-nunn merged 1 commit intomainfrom
clarbel
Nov 5, 2025
Merged

Use Clarabel instead of OSQP to solve QPP in VMCON#3971
timothy-nunn merged 1 commit intomainfrom
clarbel

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn commented Nov 5, 2025

I am noticing some non-determinisim in solver (specifically for the spherical tokamak regression test) where an "inaccurate solution" is returned from OSQP and this results in a non-deterministic step length. Clarbel was recommended for its determinism and accuracy (osqp/osqp-python#116)

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.05%. Comparing base (5eeaeff) to head (42c55e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3971   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files         123      123           
  Lines       28737    28738    +1     
=======================================
+ Hits        13234    13235    +1     
  Misses      15503    15503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn
Copy link
Copy Markdown
Collaborator Author

timothy-nunn commented Nov 5, 2025

The use of Clarabel does not have an impact on convergence compared to current PROCESS:

These are the results of running 2000 input files within +/-30% of the starting position of the ST and LT-NOF regression tests (1000 from each test).
image

@timothy-nunn timothy-nunn self-assigned this Nov 5, 2025
@timothy-nunn timothy-nunn changed the title Use Clarbel instead of OSQP to solve QPP in VMCON Use Clarabel instead of OSQP to solve QPP in VMCON Nov 5, 2025
@timothy-nunn timothy-nunn marked this pull request as ready for review November 5, 2025 15:45
@timothy-nunn timothy-nunn requested a review from clmould November 5, 2025 16:12
@timothy-nunn timothy-nunn merged commit 8dd9e07 into main Nov 5, 2025
14 of 18 checks passed
@timothy-nunn timothy-nunn deleted the clarbel branch November 5, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants