🎨 Add effective charge and ionisation profiles to plot_proc#3977
Merged
timothy-nunn merged 12 commits intomainfrom Nov 17, 2025
Merged
🎨 Add effective charge and ionisation profiles to plot_proc#3977timothy-nunn merged 12 commits intomainfrom
plot_proc#3977timothy-nunn merged 12 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3977 +/- ##
==========================================
- Coverage 46.09% 46.01% -0.08%
==========================================
Files 123 123
Lines 28888 28957 +69
==========================================
+ Hits 13316 13325 +9
- Misses 15572 15632 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
j-a-foster
approved these changes
Nov 11, 2025
Collaborator
j-a-foster
left a comment
There was a problem hiding this comment.
Happy with changes. Some of the variable replaces need checking though.
d35bb8e to
b81bc25
Compare
timothy-nunn
approved these changes
Nov 13, 2025
timothy-nunn
requested changes
Nov 14, 2025
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Whoops, missed the error on two of the regression tests
…ations and average ionization state representation
…plasma_effective_vol_avg` for consistency across the codebase
… to improve consistency across the codebase
b81bc25 to
951a65c
Compare
timothy-nunn
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the naming conventions for electric charge-related variables and updates example data files to reflect these changes. The main focus is on replacing the old
zeffandzeffaiidentifiers with new, more descriptive variable names that follow the updated standards. Additionally, documentation is improved to clarify the new conventions.✨ New variables
n_charge_plasma_effective_profilen_charge_impurity_profile🔄 Renames
zeff->n_charge_plasma_effective_vol_avgzeffai->n_charge_plasma_effective_mass_weighted_vol_avg📓 Documentation
documentation/development/standards.md, introducing thecharge_andn_charge_prefixes for electric charges and charge numbers, respectively.🎨 Output
These changes ensure consistency and clarity in variable naming, making the codebase easier to maintain and understand.## Description
Checklist
I confirm that I have completed the following checks: