Skip to content

Update examples to remove obsolete variables#3978

Merged
timothy-nunn merged 2 commits intomainfrom
3950-update-obsolete-variable-names-left-in-codebase
Nov 12, 2025
Merged

Update examples to remove obsolete variables#3978
timothy-nunn merged 2 commits intomainfrom
3950-update-obsolete-variable-names-left-in-codebase

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Nov 7, 2025

Description

Closes #3950
Update the example/data files to remove obsolete variables. Removed the scan_MFILE.DAT and the plot_scan from examples.ipynb as that function is used in scan.ipynb.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Nov 7, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.09%. Comparing base (b0a0128) to head (107272c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3978   +/-   ##
=======================================
  Coverage   46.09%   46.09%           
=======================================
  Files         123      123           
  Lines       28888    28888           
=======================================
  Hits        13316    13316           
  Misses      15572    15572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould requested a review from timothy-nunn November 7, 2025 17:07
Comment thread examples/data/csv_output_large_tokamak_MFILE.DAT Outdated
@clmould clmould force-pushed the 3950-update-obsolete-variable-names-left-in-codebase branch from 03e60e7 to 107272c Compare November 12, 2025 11:31
@clmould clmould requested a review from timothy-nunn November 12, 2025 11:43
@timothy-nunn timothy-nunn merged commit 61f3b04 into main Nov 12, 2025
26 of 27 checks passed
@timothy-nunn timothy-nunn deleted the 3950-update-obsolete-variable-names-left-in-codebase branch November 12, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update obsolete variable names left in codebase

3 participants