Replace setup.py with pyproject.toml and other metadata changes#3983
Replace setup.py with pyproject.toml and other metadata changes#3983timothy-nunn merged 6 commits intoukaea:mainfrom
setup.py with pyproject.toml and other metadata changes#3983Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3983 +/- ##
==========================================
+ Coverage 45.99% 46.03% +0.04%
==========================================
Files 123 123
Lines 29002 28964 -38
==========================================
- Hits 13340 13335 -5
+ Misses 15662 15629 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Adding some support for the Line 15 in 2cd900d This change would mean not having to remember to update the number in the future. |
3921f01 to
d0e578d
Compare
timothy-nunn
left a comment
There was a problem hiding this comment.
I have a few suggestions about which dependencies should be installed in the testing jobs. I think part of our tests job is to check we have our dependencies sorted out hence we should be strict with which dependencies are installed in these jobs--other jobs dont matter so much.
There was a problem hiding this comment.
Some new issues should be created from this:
- Transform our CI to use hatch (will solve the Python version element of Matrix unit tests with Python version and OS #3848)
- Enable more ruff rules and fix any issues
There was a problem hiding this comment.
May I recommend https://github.com/Fusion-Power-Plant-Framework/fppf-actions or modifications to it to unite our CI
Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
Description
Closes #3669
This changes the install to use a pyproject.toml. Some things to consider when reviewing:
Checklist
I confirm that I have completed the following checks: