Add EBW/ECRH coupling efficiency graph plotting functionality#3984
Merged
timothy-nunn merged 3 commits intomainfrom Dec 5, 2025
Merged
Add EBW/ECRH coupling efficiency graph plotting functionality#3984timothy-nunn merged 3 commits intomainfrom
timothy-nunn merged 3 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3984 +/- ##
==========================================
- Coverage 46.03% 45.99% -0.05%
==========================================
Files 123 123
Lines 28964 28998 +34
==========================================
+ Hits 13335 13337 +2
- Misses 15629 15661 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6c14d7b to
305ac71
Compare
…mprove axis labels
j-a-foster
approved these changes
Dec 5, 2025
Collaborator
j-a-foster
left a comment
There was a problem hiding this comment.
Happy with plot addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new plot to visualize the coupling efficiency of Electron Bernstein Waves (EBW) and Electron Cyclotron Resonance Heating (ECRH) as a function of the toroidal B-field. The implementation includes the creation of a new plotting function, integration of this plot into the main plotting workflow, and necessary imports and resource management updates. Additionally, there is a minor correction in the calculation of the electron cyclotron frequency.
New EBW/ECRH Coupling Efficiency Plot Integration:
plot_ebw_ecrh_coupling_graphtoplot_proc.pythat generates a plot of EBW and ECRH coupling efficiency versus the on-axis toroidal B-field for the first three harmonics, including both O-mode and X-mode for ECRH. The plot is styled with different colors and line styles for clarity.fig26/page26) for the plot.main_plotand saving/closing the figure in the appropriate places.ElectronBernsteinandElectronCyclotronfromprocess.current_driveto support the new plotting function.🐛 Bugs
1.0e19in the calculation of the electron cyclotron frequency inelectron_cyclotron_freethy. This caused the EC to always never couple 🤯Checklist
I confirm that I have completed the following checks: