Add dimensionless current drive eff#3985
Merged
timothy-nunn merged 7 commits intomainfrom Nov 17, 2025
Merged
Conversation
…nd secondary heating methods
…e plot labels for clarity
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3985 +/- ##
==========================================
+ Coverage 46.09% 46.10% +0.01%
==========================================
Files 123 123
Lines 28888 28901 +13
==========================================
+ Hits 13316 13326 +10
- Misses 15572 15575 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4ab6629 to
37a265c
Compare
timothy-nunn
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the calculation, storage, and output of the dimensionless current drive efficiency (ζ) for both primary and secondary heating and current drive (HCD) systems. Additionally, a unit test for the new calculation is included.
Current Drive Efficiency Enhancements:
CurrentDrive.cudriv, using a new methodcalculate_dimensionless_current_drive_efficiency. The results are stored ineta_cd_dimensionless_hcd_primaryandeta_cd_dimensionless_hcd_secondary.current_drive_variables.pyto include new fields for storing ζ values, and initialized them appropriately.🎨 Output
Testing:
calculate_dimensionless_current_drive_efficiencyto verify its correctness for a simple case.## DescriptionChecklist
I confirm that I have completed the following checks: