Skip to content

remove unnecessary logging and comments#3988

Merged
timothy-nunn merged 2 commits intomainfrom
remove-unnecessary-logging
Nov 18, 2025
Merged

remove unnecessary logging and comments#3988
timothy-nunn merged 2 commits intomainfrom
remove-unnecessary-logging

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Nov 17, 2025

Description

Closes #3982

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould requested a review from timothy-nunn November 17, 2025 16:57
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.04%. Comparing base (f59059d) to head (9ff05d0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/io/mfile.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3988      +/-   ##
==========================================
+ Coverage   46.03%   46.04%   +0.01%     
==========================================
  Files         123      123              
  Lines       28970    28961       -9     
==========================================
  Hits        13335    13335              
+ Misses      15635    15626       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould requested a review from je-cook November 17, 2025 17:22
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another bit of code that can be eliminated since you've already removed some of it.

Comment thread process/io/mfile.py Outdated
Comment on lines +96 to +97
except KeyError:
raise # or substitute with any other exception type you want
raise
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
except KeyError:
raise # or substitute with any other exception type you want
raise

This is just catching the KeyError and then immediately raising it again... Im guessing at some point there was some logging here

@clmould clmould requested a review from timothy-nunn November 18, 2025 10:28
@timothy-nunn timothy-nunn merged commit 72ade4b into main Nov 18, 2025
18 checks passed
@timothy-nunn timothy-nunn deleted the remove-unnecessary-logging branch November 18, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Excessive debugging statements when reading MFile

3 participants