remove unnecessary logging and comments#3988
Merged
timothy-nunn merged 2 commits intomainfrom Nov 18, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3988 +/- ##
==========================================
+ Coverage 46.03% 46.04% +0.01%
==========================================
Files 123 123
Lines 28970 28961 -9
==========================================
Hits 13335 13335
+ Misses 15635 15626 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
requested changes
Nov 18, 2025
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Just another bit of code that can be eliminated since you've already removed some of it.
Comment on lines
+96
to
+97
| except KeyError: | ||
| raise # or substitute with any other exception type you want | ||
| raise |
Collaborator
There was a problem hiding this comment.
Suggested change
| except KeyError: | |
| raise # or substitute with any other exception type you want | |
| raise |
This is just catching the KeyError and then immediately raising it again... Im guessing at some point there was some logging here
timothy-nunn
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3982
Checklist
I confirm that I have completed the following checks: