Skip to content

Replace constants PI/TWOPI with numpy#3995

Merged
clmould merged 1 commit intomainfrom
3812-standardise-use-of-constants
Nov 27, 2025
Merged

Replace constants PI/TWOPI with numpy#3995
clmould merged 1 commit intomainfrom
3812-standardise-use-of-constants

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

Replaces use of our own constants.PI and constants.TWOPI with np.pi and 2.0 * np.pi, respectively.

@timothy-nunn timothy-nunn linked an issue Nov 27, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.04%. Comparing base (b06890b) to head (08744af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3995      +/-   ##
==========================================
- Coverage   46.04%   46.04%   -0.01%     
==========================================
  Files         123      123              
  Lines       28962    28961       -1     
==========================================
- Hits        13336    13335       -1     
  Misses      15626    15626              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn marked this pull request as ready for review November 27, 2025 11:05
@timothy-nunn timothy-nunn requested a review from clmould November 27, 2025 11:05
@clmould clmould merged commit a591a75 into main Nov 27, 2025
18 checks passed
@clmould clmould deleted the 3812-standardise-use-of-constants branch November 27, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardise use of constants

3 participants