Conversation
…stead of just upper
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4007 +/- ##
==========================================
- Coverage 45.89% 45.89% -0.01%
==========================================
Files 123 123
Lines 29064 29066 +2
==========================================
Hits 13340 13340
- Misses 15724 15726 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mkovari
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3998
Before, the message printing if a variable was below its lower bounds it was using the scaled_upper_bounds array so the message was wrong in some cases before:
Now it prints correctly:

Checklist
I confirm that I have completed the following checks: