Skip to content

Add low aspect ratio demo case to the tracker#4020

Merged
timothy-nunn merged 6 commits intomainfrom
3554-add-low-aspect-ratio-demo-case-to-the-tracker
Jan 21, 2026
Merged

Add low aspect ratio demo case to the tracker#4020
timothy-nunn merged 6 commits intomainfrom
3554-add-low-aspect-ratio-demo-case-to-the-tracker

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Dec 18, 2025 •
edited
Loading

Description

Closes #3554

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Dec 18, 2025 that may be closed by this pull request
Add Low Aspect Ratio DEMO case to the tracker #3554
Closed
@clmould clmould requested a review from timothy-nunn December 18, 2025 16:30
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.49%. Comparing base (5ea7543) to head (06d64c2).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4020   +/-   ##
=======================================
  Coverage   46.49%   46.49%           
=======================================
  Files         123      123           
  Lines       28777    28777           
=======================================
  Hits        13381    13381           
  Misses      15396    15396

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

timothy-nunn
timothy-nunn requested changes Dec 23, 2025
View reviewed changes
Comment thread tests/regression/input_files/A_28_R_86_350MW.IN.DAT Outdated
@clmould clmould requested a review from timothy-nunn January 5, 2026 10:57
@timothy-nunn
Copy link
Copy Markdown
Collaborator

timothy-nunn commented Jan 7, 2026

Just need to check that @ajpearcey is happy with this file:
low_aspect_ratio_DEMO.MFILE.DAT.txt
low_aspect_ratio_DEMO.MFILE.DATSUMMARY.pdf
low_aspect_ratio_DEMO.OUT.DAT.txt

@timothy-nunn timothy-nunn requested a review from ajpearcey January 7, 2026 09:15
ajpearcey
ajpearcey requested changes Jan 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ajpearcey ajpearcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The burn time in this file drops from 2.11 hours to 1.4 hours. I will investigate why, I'm not comfortable adding this to the tracker until we understand this change.

@timothy-nunn
Copy link
Copy Markdown
Collaborator

timothy-nunn commented Jan 7, 2026

The burn time in this file drops from 2.11 hours to 1.4 hours. I will investigate why, I'm not comfortable adding this to the tracker until we understand this change.

👍. Is there a constraint we can use to get the burn time back up? Or is already a constraint that is being violated.

@timothy-nunn timothy-nunn marked this pull request as draft January 15, 2026 15:37
@timothy-nunn
Copy link
Copy Markdown
Collaborator

timothy-nunn commented Jan 15, 2026

@clmould I am told that there is a new file? This merge will also need to go in behind #3947

@clmould clmould force-pushed the 3554-add-low-aspect-ratio-demo-case-to-the-tracker branch from 4698b7f to 8c2489e Compare January 20, 2026 11:38
@clmould
Copy link
Copy Markdown
Collaborator Author

clmould commented Jan 20, 2026 •
edited
Loading

Added the new file now and rebased @timothy-nunn
low_aspect_ratio_DEMO results.zip

@clmould clmould marked this pull request as ready for review January 20, 2026 11:39
@clmould clmould force-pushed the 3554-add-low-aspect-ratio-demo-case-to-the-tracker branch from 8c2489e to 06d64c2 Compare January 20, 2026 11:50
@clmould clmould requested a review from ajpearcey January 20, 2026 11:58
ajpearcey
ajpearcey approved these changes Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ajpearcey ajpearcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@timothy-nunn timothy-nunn merged commit 1cea803 into main Jan 21, 2026
16 of 20 checks passed
@timothy-nunn timothy-nunn deleted the 3554-add-low-aspect-ratio-demo-case-to-the-tracker branch January 21, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timothy-nunn timothy-nunn timothy-nunn approved these changes

@ajpearcey ajpearcey ajpearcey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Low Aspect Ratio DEMO case to the tracker

4 participants

@clmould @codecov-commenter @timothy-nunn @ajpearcey