Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4037 +/- ##
=======================================
Coverage 46.30% 46.30%
=======================================
Files 123 123
Lines 28961 28961
=======================================
Hits 13411 13411
Misses 15550 15550 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chris-ashe
requested changes
Jan 9, 2026
| ) | ||
| radius_beam_tangency_max = 0.0e0 | ||
|
|
||
| current_drive_variables.radius_beam_tangency = radius_beam_tangency |
Collaborator
There was a problem hiding this comment.
Why are these variables not being assigned at the function output where it is called?
Collaborator
Author
There was a problem hiding this comment.
Just moved it to where the fn is called
… values in mfile are not 0.0
edad117 to
e8efeda
Compare
chris-ashe
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3979
Description
Checklist
I confirm that I have completed the following checks: