Preempt possible unit test failures from ill-conditioned matrices#4047
Merged
Preempt possible unit test failures from ill-conditioned matrices#4047
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
=======================================
Coverage 46.29% 46.29%
=======================================
Files 123 123
Lines 28976 28976
=======================================
Hits 13415 13415
Misses 15561 15561 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
force-pushed
the
random_unit_test_failing
branch
from
f0663dc to
1e179af
Compare
je-cook
reviewed
Jan 16, 2026
je-cook
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4000
The random unit test failures come from linear algebra on ill-conditioned systems of equations. Some systems (combinations of OS, software, processor, architecture) produce slightly different results for the same calculations near system epsilon. We can identify systems where this will happen and skip problematic tests.