Skip to content

vacuum dataclass#4189

Merged
timothy-nunn merged 5 commits intomainfrom
Vacuum-DataClass
Apr 16, 2026
Merged

vacuum dataclass#4189
timothy-nunn merged 5 commits intomainfrom
Vacuum-DataClass

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Apr 14, 2026

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould force-pushed the Vacuum-DataClass branch 2 times, most recently from ccbf8f7 to 973d180 Compare April 14, 2026 16:26
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 88.57143% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.60%. Comparing base (7b5ea2b) to head (dec8601).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
process/models/ife.py 0.00% 5 Missing ⚠️
process/models/vacuum.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4189      +/-   ##
==========================================
- Coverage   49.63%   49.60%   -0.03%     
==========================================
  Files         148      148              
  Lines       29746    29729      -17     
==========================================
- Hits        14764    14747      -17     
  Misses      14982    14982              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould marked this pull request as ready for review April 14, 2026 17:20
@clmould clmould requested a review from a team as a code owner April 14, 2026 17:20
@clmould clmould assigned timothy-nunn and unassigned timothy-nunn Apr 14, 2026
Comment thread tests/unit/test_costs_1990.py Outdated
@clmould clmould requested a review from timothy-nunn April 15, 2026 10:24
Comment thread tests/unit/test_costs_1990.py Outdated
@clmould clmould requested a review from timothy-nunn April 16, 2026 09:17
@timothy-nunn timothy-nunn enabled auto-merge (squash) April 16, 2026 09:25
@timothy-nunn timothy-nunn merged commit f565bb1 into main Apr 16, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the Vacuum-DataClass branch April 16, 2026 09:27
@je-cook je-cook added the Data structure Issues related to the data structure label Apr 17, 2026
grmtrkngtn pushed a commit that referenced this pull request Apr 17, 2026
* vacuum dataclass

* fix

* fix conflict

* fix pre-commit error

* review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants