❇️ Creating generic engineering models file

[chris-ashe]

This pull request refactors and improves the engineering methods for coolant friction, heat transfer, and material thermal conductivity calculations. It modularizes these methods into dedicated files, updates documentation to match the new structure, and replaces legacy methods with more accurate and documented alternatives in the codebase.

Engineering methods modularization and code refactoring:

• Introduced new engineering utility modules: process/models/engineering/pumping.py now contains darcy_friction_haaland, gnielinski_heat_transfer_coefficient, and calculate_reynolds_number, while process/models/engineering/materials.py provides eurofer97_thermal_conductivity. The codebase now imports and uses these functions instead of legacy, model-specific methods.

• Updated process/models/fw.py and process/models/blankets/blanket_library.py to use the new generic methods for heat transfer, friction factor, and thermal conductivity, replacing previous method calls with the new utility functions. [

Documentation improvements and restructuring:

• Added detailed documentation for the new generic engineering methods in documentation/source/eng-models/generic_methods/pumping.md and materials.md, including equations, references, and validity ranges for each method.

• Updated the main engineering model documentation (fw-blanket.md and blanket_overview.md) to reference the new generic methods, replacing references to old, model-specific methods with links to the new documentation sections.

• Removed the inlined method documentation from fw-blanket.md that is now covered by the new generic methods documentation, and moved relevant references to the new materials documentation.
  Documentation navigation update:

• Updated mkdocs.yml to include the new "Generic Engineering Methods" section in the documentation navigation, with links to Pumping and Materials methods.

Checklist

I confirm that I have completed the following checks:

• My changes follow the PROCESS style guide
• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.12%. Comparing base (25b9f07) to head (bc0c38e).

Files with missing lines	Patch %	Lines
process/models/engineering/pumping.py	87.50%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4211      +/-   ##
==========================================
+ Coverage   52.10%   52.12%   +0.01%     
==========================================
  Files         148      150       +2     
  Lines       30389    30401      +12     
==========================================
+ Hits        15835    15847      +12     
  Misses      14554    14554              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR factors out common “generic engineering” calculations (pumping + materials property correlations) from specific models into reusable modules, and updates model code, docs, and unit tests accordingly.

Changes:

• Extracts Haaland friction factor, Gnielinski heat transfer coefficient, Reynolds number, and Eurofer97 thermal conductivity into process.models.engineering.*.
• Updates FW and blanket pumping code to call the new generic functions, and relocates unit tests into tests/unit/models/engineering/.
• Adds new MkDocs pages and navigation entries for the generic engineering methods.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
process/models/fw.py	Switches FW temperature calcs to use new generic materials/pumping functions.
process/models/blankets/blanket_library.py	Uses new pumping helpers for Reynolds number + friction factor in pressure drop calculations.
process/models/engineering/pumping.py	New generic pumping utilities (Haaland, Gnielinski, Reynolds).
process/models/engineering/materials.py	New generic materials utility (Eurofer97 thermal conductivity).
process/models/engineering/__init__.py	Introduces the engineering package.
tests/unit/models/test_fw.py	Removes tests for logic moved into generic engineering modules.
tests/unit/models/engineering/test_pumping.py	Adds unit tests for new pumping helper functions.
tests/unit/models/engineering/test_materials.py	Adds unit test for Eurofer97 conductivity helper.
mkdocs.yml	Adds nav entries for “Generic Engineering Methods”.
documentation/source/eng-models/generic_methods/pumping.md	New documentation page for pumping helper methods.
documentation/source/eng-models/generic_methods/materials.md	New documentation page for materials helper methods.
documentation/source/eng-models/fw-blanket.md	Updates references to point to the new generic methods docs.
documentation/source/eng-models/blanket_overview.md	Links Darcy friction reference to the new pumping methods page.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.