-
Notifications
You must be signed in to change notification settings - Fork 18
Add model type output to physics plot proc #4214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chris-ashe
wants to merge
28
commits into
main
Choose a base branch
from
add_model_type_output_to_physics_plot_proc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
b060812
Fix formula in plot_main_plasma_information for plasma separatrix pow…
chris-ashe be740c1
Add output for plasma diamagnetic current fraction scaling law
chris-ashe 4671b50
Add BootstrapCurrentFractionModel to summary plot output
chris-ashe ab094e0
Add output for selected diamagnetic current fraction model in plasma …
chris-ashe b55b4cd
Add alpha particle confinement time ratio to plasma information plot
chris-ashe 0fd160c
Add IndInternalNormModel for normalized internal inductance and updat…
chris-ashe fc68c98
Update plasma volt-second output and enhance variable descriptions in…
chris-ashe 1830795
Refactor plasma normalised internal inductance output and update comm…
chris-ashe f03dcb8
Update unit representations in output strings for clarity
chris-ashe 53494b5
Update output variable labels in plasma_fields for clarity and consis…
chris-ashe 2cf0cd7
Refactor plasma current output method and enhance variable descriptio…
chris-ashe 0ba313a
Enhance output variable labels in PlasmaBeta for clarity and consistency
chris-ashe 0683b30
Add max normalised beta comparison plot and update titles for clarity
chris-ashe f679789
Enhance plasma output formatting and add pressure data to physics model
chris-ashe 7cec72f
Add density limit model to physics plot and enhance output information
chris-ashe 93391e1
Fix unit formatting in constraint equations for consistency
chris-ashe f9094d0
Enhance output variable labels in PlasmaGeom for clarity and consistency
chris-ashe ce665de
Enhance PlasmaProfileShapeType Enum with Descriptions
chris-ashe 6683aa7
Add ITER physics basis elongation calculation and update output forma…
chris-ashe 00ca811
Update integration test file
chris-ashe d160390
move call to output fn
clmould 8983e04
Enhance output variable labels in physics models for clarity and cons…
chris-ashe 9e536f8
Update process/core/io/plot/summary.py
chris-ashe 52e17d0
Update documentation/source/physics-models/plasma_geometry.md
chris-ashe b162cde
Fix reference formatting in plasma geometry and confinement time models
chris-ashe 7cee21f
Enhance output formatting and clarity in physics models
chris-ashe 9dddecf
Add output handling for plasma exhaust results in physics model
chris-ashe e2cd523
Refactor output handling for current drive efficiencies and plasma ig…
chris-ashe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plot_max_normalised_beta_comparisonpasses scalar values (frommfile.get(..., scan=scan)) directly intoaxis.violinplot()/axis.boxplot(). Matplotlib expects each dataset to be a 1D sequence; scalars will raise at runtime (0-d arrays are not sized). Consider switching this to a simple bar/scatter comparison across models, or wrap each value as a 1-element list/array and set explicit positions + x tick labels so the plot is meaningful (and avoid plotting all points at x=1).