Get var descriptions from new dataclass structure#4216
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4216 +/- ##
==========================================
+ Coverage 52.13% 52.14% +0.01%
==========================================
Files 148 148
Lines 30419 30429 +10
==========================================
+ Hits 15858 15868 +10
Misses 14561 14561 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
reviewed
May 5, 2026
Comment on lines
+489
to
+493
| if isinstance(node1, ast.AnnAssign) and not isinstance( | ||
| node2, ast.Expr | ||
| ): | ||
| # if no docstring for variable, have a blank description | ||
| var_names_and_descriptions[node1.target.id] = "" |
Collaborator
There was a problem hiding this comment.
Is this second condition needed? Surely any situation other than declaration->docstring should have a blank description so this could just be an else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4215
Checklist
I confirm that I have completed the following checks: