Add new menard scaling plasma geometry and docs#4224
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4224 +/- ##
==========================================
- Coverage 52.15% 51.78% -0.37%
==========================================
Files 148 150 +2
Lines 30435 30204 -231
==========================================
- Hits 15874 15642 -232
- Misses 14561 14562 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chris-ashe
requested changes
May 6, 2026
| $$ | ||
|
|
||
| --------------------------------------------------------------------- | ||
| - `i_plasma_geometry = 12` -- The elongation is calculated directly from the aspect ratio based on a scaling for the maximum contrallable elongation in a spherical tokamak[^5] and asssuming a constant $li(3)$. |
Collaborator
There was a problem hiding this comment.
The reference is broken
| $$ | ||
|
|
||
| --------------------------------------------------------------------- | ||
| - `i_plasma_geometry = 12` -- The elongation is calculated directly from the aspect ratio based on a scaling for the maximum contrallable elongation in a spherical tokamak[^5] and asssuming a constant $li(3)$. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - `i_plasma_geometry = 12` -- The elongation is calculated directly from the aspect ratio based on a scaling for the maximum contrallable elongation in a spherical tokamak[^5] and asssuming a constant $li(3)$. | |
| - `i_plasma_geometry = 12` -- The elongation is calculated directly from the aspect ratio based on a scaling for the maximum contrallable elongation in a spherical tokamak[^5] and asssuming a constant $l_i(3)$. |
| [^3]: H. Zohm et al, *'On the Physics Guidelines for a Tokamak DEMO'*, | ||
| FTP/3-3, Proc. IAEA Fusion Energy Conference, October 2012, San Diego | ||
| [^4]: Menard, J.E. & Brown, T. & El-Guebaly, L. & Boyer, M. & Canik, J. & Colling, Bethany & Raman, Roger & Wang, Z. & Zhai, Yunbo & Buxton, Peter & Covele, B. & D’Angelo, C. & Davis, Andrew & Gerhardt, S. & Gryaznevich, M. & Harb, Moataz & Hender, T.C. & Kaye, S. & Kingham, David & Woolley, R.. (2016). *Fusion nuclear science facilities and pilot plants based on the spherical tokamak.* Nuclear Fusion. 56. 106023. 10.1088/0029-5515/56/10/106023. | ||
| [^5] J.E. Menard, S.C. Jardin, S.M. Kaye, C.E. Kessel and J. Manickam (1997) *Ideal MHD stability limits of low aspect ratio tokamak plasmas.* Nuclear Fusion. 37. 595. 10.1088/0029-5515/37/5/I03 |
Collaborator
There was a problem hiding this comment.
The reference name could actually be [^menard_1997] to make it easier to know what it is
| [^3]: H. Zohm et al, *'On the Physics Guidelines for a Tokamak DEMO'*, | ||
| FTP/3-3, Proc. IAEA Fusion Energy Conference, October 2012, San Diego | ||
| [^4]: Menard, J.E. & Brown, T. & El-Guebaly, L. & Boyer, M. & Canik, J. & Colling, Bethany & Raman, Roger & Wang, Z. & Zhai, Yunbo & Buxton, Peter & Covele, B. & D’Angelo, C. & Davis, Andrew & Gerhardt, S. & Gryaznevich, M. & Harb, Moataz & Hender, T.C. & Kaye, S. & Kingham, David & Woolley, R.. (2016). *Fusion nuclear science facilities and pilot plants based on the spherical tokamak.* Nuclear Fusion. 56. 106023. 10.1088/0029-5515/56/10/106023. | ||
| [^5] J.E. Menard, S.C. Jardin, S.M. Kaye, C.E. Kessel and J. Manickam (1997) *Ideal MHD stability limits of low aspect ratio tokamak plasmas.* Nuclear Fusion. 37. 595. 10.1088/0029-5515/37/5/I03 |
Collaborator
There was a problem hiding this comment.
Can the reference please be in IEEE format with a clickable DOI.
This website should be used: https://www.mybib.com/tools/ieee-citation-generator
| # physics_variables.triang is an input | ||
| # physics_variables.kappa found from physics_variables.aspect ratio scaling from | ||
| # J.E. Menard et al 1997 Nucl. Fusion 37 595 and assume max controllable kappa | ||
| # and assume li(3) is held constant |
Collaborator
There was a problem hiding this comment.
Suggested change
| # and assume li(3) is held constant | |
| # and assume lᵢ(3) is held constant |
| $$ | ||
|
|
||
| --------------------------------------------------------------------- | ||
| - `i_plasma_geometry = 12` -- The elongation is calculated directly from the aspect ratio based on a scaling for the maximum contrallable elongation in a spherical tokamak[^5] and asssuming a constant $li(3)$. |
Collaborator
There was a problem hiding this comment.
I believe the reference of the plot also states that its at a
| $$ | ||
|
|
||
| --------------------------------------------------------------------- | ||
| - `i_plasma_geometry = 12` -- The elongation is calculated directly from the aspect ratio based on a scaling for the maximum contrallable elongation in a spherical tokamak[^5] and asssuming a constant $li(3)$. |
Collaborator
There was a problem hiding this comment.
Need a small sentence that triangularity is input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #4134