Skip to content

First wall dataclass#4226

Merged
timothy-nunn merged 2 commits intomainfrom
FirstWall-Dataclass
May 6, 2026
Merged

First wall dataclass#4226
timothy-nunn merged 2 commits intomainfrom
FirstWall-Dataclass

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented May 6, 2026

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.80%. Comparing base (62a4d95) to head (6c4714a).

Files with missing lines Patch % Lines
process/models/stellarator/stellarator.py 0.00% 6 Missing ⚠️
process/models/ife.py 85.71% 1 Missing ⚠️
process/models/stellarator/build.py 80.00% 1 Missing ⚠️
process/models/stellarator/divertor.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4226      +/-   ##
==========================================
+ Coverage   51.78%   51.80%   +0.02%     
==========================================
  Files         150      150              
  Lines       30285    30286       +1     
==========================================
+ Hits        15684    15691       +7     
+ Misses      14601    14595       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould marked this pull request as ready for review May 6, 2026 14:16
@clmould clmould requested a review from a team as a code owner May 6, 2026 14:16
@timothy-nunn timothy-nunn merged commit 299719f into main May 6, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the FirstWall-Dataclass branch May 6, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants