Skip to content

Conversation

@aAYUSHkujur
Copy link
Contributor

I am changing syntax according to the need.

@perry-mitchell perry-mitchell merged commit 09127c1 into ulid:master Feb 3, 2025
@perry-mitchell perry-mitchell mentioned this pull request Feb 3, 2025
@nukosuke
Copy link
Contributor

nukosuke commented Feb 21, 2025

There is a regression in current master branch.

(master)> yarn build
(master)> git diff
diff --git a/dist/index.js b/dist/index.js
index a7aedbf..ad91831 100644
--- a/dist/index.js
+++ b/dist/index.js
@@ -56,7 +56,7 @@ export function encodeTime(now, len) {
     if (now < 0) {
         throw createError("time must be positive");
     }
-    if (Number.isInteger(Number(now)) === false) { 
+    if (Number.isInteger(now) === false) {
         throw createError("time must be an integer");
     }
     let mod;

This PR modifies the transpiled distribution code and does not appear to be an appropriate fix.
The corresponding section in lib/index.ts needs to be modified in the same way.

@nukosuke nukosuke mentioned this pull request Feb 21, 2025
@nukosuke
Copy link
Contributor

I created PR for this. take a look at #114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants