Skip to content

change subject.unsubscribe() to subject.complete() #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sougiovn wants to merge 4 commits into from
Closed

change subject.unsubscribe() to subject.complete() #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98f4d7c
change subject.unsubscribe() to subject.complete()
sougiovn Sep 20, 2017
a525168
Changed version to 0.0.1
sougiovn Oct 17, 2017
b945a9b
Back to version 0.0.0 for publishing auto increment version
sougiovn Oct 17, 2017
4dbfd2f
Merge branch 'master' into master
sougiovn May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,6 @@ dist

# Docs
gh-pages

# VScode stop adding .angulardoc.json
.angulardoc.json
3 changes: 2 additions & 1 deletion src/ngxerror.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ export class NgxErrorDirective implements OnInit, OnDestroy, DoCheck {
}

ngOnDestroy() {
this._states.complete();
this.subscription.unsubscribe();
}

}
}
12 changes: 8 additions & 4 deletions src/ngxerrors.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class NgxErrorsDirective implements OnChanges, OnDestroy, AfterViewInit {
@Input('ngxErrors')
controlName: string;

subject = new BehaviorSubject<ErrorDetails>(null);
subject: BehaviorSubject<ErrorDetails>;

control: AbstractControl;

Expand Down Expand Up @@ -71,10 +71,14 @@ export class NgxErrorsDirective implements OnChanges, OnDestroy, AfterViewInit {
}
}

ngOnInit() {
this.subject = new BehaviorSubject<ErrorDetails>(null);
}

ngOnChanges() {
this.control = this.form.control.get(this.controlName);
}

ngAfterViewInit() {
setTimeout(() => {
this.checkStatus();
Expand All @@ -83,7 +87,7 @@ export class NgxErrorsDirective implements OnChanges, OnDestroy, AfterViewInit {
}

ngOnDestroy() {
this.subject.unsubscribe();
this.subject.complete();
}

}
}