YAMLParser: some small fixes#50
Closed
YaseenAlk wants to merge 4 commits intouml-robotics:masterfrom
YaseenAlk:pullreq-smallfixes
Closed
YAMLParser: some small fixes#50YaseenAlk wants to merge 4 commits intouml-robotics:masterfrom YaseenAlk:pullreq-smallfixes
YaseenAlk wants to merge 4 commits intouml-robotics:masterfrom
YaseenAlk:pullreq-smallfixes
Conversation
Author
|
I just noticed the fork by Xamla, and I now realize that this PR might just be reinventing the wheel... Feel free to implement any commits if you find them useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consists of 4 commits to YAMLParser:
I used VS Code to open the repo, and I opened YAMLParser with Visual Studio. Updated the gitignore to ignore the config files for these 2 situations.
This commit does not (or rather, should not) change any part of YAMLParser's functionality. It was just to prep the project so that I could run YAMLParser on Mac/Linux using .NET Core CLI. I'm almost done making the necessary conversions, and might make a separate pull request in case that also sounds like a useful addition.
Interestingly, I ran into an issue in YAMLParser where the following lines in a .msg file were not being parsed correctly:
This commit (hopefully) fixes any issues with string constants.
While testing the .NET Core version of YAMLParser that I've been editing, I ran into an elusive problem where
GenerateFiles()in Program.cs was stuck in an infinite loop while trying to MD5 hash some .msg files. The issue turned out to be inPrepareToHash(): within the method,irm.Stuff[i].Definerwas always null, because the program could not resolve theSingleTypes of the messages without std_msgs first being processed. There may be a smarter way to fix this issue, but the easiest solution is to just avoid generating any files if std_msgs was not an included directory.