added stinson filter #251
Merged
added stinson filter #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
una
requested changes
Nov 2, 2016
source/scss/stinson.scss
Outdated
| // } | ||
| @mixin stinson($filters...) { | ||
| @include filter-base; | ||
| filter: contrast(0.75) saturate(0.85) $filters; |
Owner
There was a problem hiding this comment.
I would add a bit of brightness too, as its looking a bit darker than the filer, maybe brightness(1.15)
| @include filter-base; | ||
| filter: contrast(0.75) saturate(0.85) $filters; | ||
|
|
||
| @content; |
Owner
There was a problem hiding this comment.
I would also add a pseudo element with a light orange light to bring up the warmth in the shadows. This is what I tried and it looked pretty close:
&::before {
background: rgba(240, 149, 128, .2);
mix-blend-mode: soft-light;
}
Before changes:
After:
LadyCarni
force-pushed
the
added-stinson-filter
branch
from
dea7458 to
75bdff5
Compare
Contributor
Author
|
I have made the requested changes and here's the screenshot:
|
una
approved these changes
Nov 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #21
Animated GIFs showing the on/off of the filter: