Patch to fix issues with Uploading files with MultipleFileAttachmentField#28
Open
micahsheets wants to merge 8 commits intounclecheese:masterfrom
micahsheets:master
Open
Patch to fix issues with Uploading files with MultipleFileAttachmentField#28micahsheets wants to merge 8 commits intounclecheese:masterfrom micahsheets:master
micahsheets wants to merge 8 commits intounclecheese:masterfrom
micahsheets:master
Conversation
…have not been extended with "ManyManySortable".
…aObject has been extended with "ManyManySortable". Elements for changing sort order are not displayed and specific hidden fields are not sent to the browser.
…anyManySort ASC' so I removed the ability to set or change the sort order of the function return.
…e saved. Without this attached files using MultiFileAttachementField would upload but would not attach to the object.
Contributor
Author
|
New update to MultiplefileAttachmentField to fix issue with non-sortable file attachment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows for the field to work normally if the file relationship class has not been set to use ManyManySortable via _config.php with:
[code]
ManyManySortable::add_sortable_many_many_relations(array('Class' => 'RelationName'));
[\code]
This patch also fixes issues that were causing errors when uploading using "From your computer".
NOTE: The Drag and Drop feature is still not functioning.