Skip to content

Conversation

@tarkatronic
Copy link
Contributor

This is a follow-up to #61, this time using time.Time structs rather than Unix timestamps. This makes it easier to format them for our various outputs.

@tarkatronic tarkatronic requested review from a team and JoseAngel1196 June 13, 2023 21:39
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #64 (ed78a24) into main (1dfce26) will increase coverage by 0.09%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   52.01%   52.11%   +0.09%     
==========================================
  Files          13       13              
  Lines         496      497       +1     
==========================================
+ Hits          258      259       +1     
  Misses        235      235              
  Partials        3        3              
Flag Coverage Δ
unittests 52.11% <83.33%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/scan.go 0.00% <0.00%> (ø)
reporting/console.go 92.68% <100.00%> (+0.18%) ⬆️
reporting/slack.go 95.23% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tarkatronic tarkatronic merged commit af5ceee into main Jun 13, 2023
@tarkatronic tarkatronic deleted the fix/reporttime-time-objects branch June 13, 2023 21:49
@tarkatronic tarkatronic added this to the Version 1.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants