`withUniwind`: Custom mapping overrides default `className` and `style` merging

[ycmjason]

What happened?

When no custom mapping is provided, the wrapped component will merge className and style as expected.

But when when custom mapping is provided, there seems to be no way to replicate this merging behaviour?

Steps to Reproduce

1. call withUniwind on some component providing custom mapping (or not)
2. Try to provide className and style together

If custom mapping is not provided, observe that className and style are merged.
If custom mapping is provided, (with className -> style mapping), style gets ignored.
If custom mapping is provided, (without className -> style mapping), className does not exist in the wrapped component, even provided is ignored.

Snack or Repository Link

https://github.com/ycmjason/uniwind-playground/tree/reproduction-with-unistyles

Uniwind version

1.0.5

React Native Version

0.81.5

Platforms

Android, iOS

Expo

Yes

Additional information

• I've searched for similar issues in this repository and found none

[ycmjason]

A current work around is to double wrap with withUniwind.

const UniAwesomeWorkaround = withUniwind(withUniwind(Awesome), {
  propNeedMapping: {
    fromClassName: 'className',
    styleProperty: 'accentColor',
  },
});

withUniwind(Awesome) will enable className and style merging. And the outter call enable passing accentColor to propNeedMapping.

[Brentlok]

Hi, it only works with either manual or auto mode. Not both at the same time

I guess it's not clearly described in the docs. We will update them

I initially incorrectly understood the issue, sorry about that...
Yes it works differently now, style is not merged with className when using manual mapping. For auto mapping it's actually passing styles as array [classNameStyle, inlineStyle] it should likely do the same for manual mapping or just merge those two objects