You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed theme variable updates to only apply CSS variables for the currently active theme, preventing unintended global variable exposure from inactive themes.
✏️ Tip: You can customize this high-level summary in your review settings.
This change fixes an inconsistency in updateCSSVariables by conditionally applying CSS variables only when the updated theme matches the current theme, preventing stale values from non-current themes overwriting the active theme's variables.
Modified updateCSSVariables to guard CSS variable application with theme matching checks. Global CSS variables and applyCSSVariable invocations now only execute when the updated theme is the current theme, preserving the active theme's state and preventing cross-theme value leakage.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
jpudysz
Poem
🐰 A rabbit hops through theme-colored lands,
Where light and dark now dance in harmony,
No more confusion from careless hands—
Each theme respects its own decree,
Updates flow where they should be! 🌙✨
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The title accurately describes the main change: conditionally updating CSS variables only for the current theme instead of all themes.
Linked Issues check
✅ Passed
The PR addresses the root cause of issue #343 by ensuring updateCSSVariables only applies to the current theme, preventing theme value corruption at app startup.
Out of Scope Changes check
✅ Passed
All changes are directly related to fixing the updateCSSVariables inconsistency issue; no unrelated modifications detected.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #343
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.