Skip to content

Conversation

@AEApple
Copy link
Contributor

@AEApple AEApple commented Mar 11, 2025

CLDR-18400

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@AEApple AEApple self-assigned this Mar 11, 2025
@github-actions github-actions bot added the Site Update Updates docs/site label Mar 11, 2025
@github-actions
Copy link

✨ deployed to https://44521519.cldr.pages.dev

@AEApple
Copy link
Contributor Author

AEApple commented Mar 11, 2025

@srl295 - Is this along the lines of what you are thinking? If so I'll fix the error and update the rest of the table.

srl295
srl295 previously approved these changes Mar 11, 2025
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly seems more manageable!

@AEApple
Copy link
Contributor Author

AEApple commented Mar 11, 2025

Certainly seems more manageable!

Okay, I'll update the rest then.

CLDR-18400

Update the links for the remaining versions. Fix visible errors in formatting.
@github-actions
Copy link

✨ deployed to https://9aaa9b29.cldr.pages.dev

CLDR-18400

Fix more table formatting errors
@github-actions
Copy link

✨ deployed to https://bf21ad6d.cldr.pages.dev

@AEApple AEApple requested a review from srl295 March 11, 2025 15:15
@DavidLRowe
Copy link
Contributor

Out of curiosity I clicked on the "please see This Page for how to fix" link and got a 404 error (trying to go to https://cldr.unicode.org/development/main-rename).

srl295
srl295 previously approved these changes Mar 11, 2025
@AEApple
Copy link
Contributor Author

AEApple commented Mar 11, 2025

Out of curiosity I clicked on the "please see This Page for how to fix" link and got a 404 error (trying to go to https://cldr.unicode.org/development/main-rename).

Can you file a ticket?

@DavidLRowe
Copy link
Contributor

@AEApple
Copy link
Contributor Author

AEApple commented Mar 11, 2025

@macchiati - Try out the table in the preview. I just formatted the links at the bottom (which are not visible on the site) so anyone can read them easily. I can add a markdown comment to explain how to update the table if that would be helpful? I had been planning to put it on a different page.

@macchiati
Copy link
Member

All works great, with a couple of exceptions. Looks like extra parens.

latest-delta-dtd)
dev-delta-dtd

Also, for latest we should use:
https://www.unicode.org/cldr/charts/latest/supplemental/dtd_deltas.html

And for dev we should use
https://www.unicode.org/cldr/charts/dev/supplemental/dtd_deltas.html

That way we never have to change those (and the dev one was really bad).

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two link changes, OW ok. I'm also running the w3 validator on the generated page, and will post when finished.

[latest-charts]: https://www.unicode.org/cldr/charts/46/index.html
[latest-ldml]: https://www.unicode.org/reports/tr35/
[latest-tickets]: https://unicode-org.atlassian.net/issues/?jql=project%20%3D%20CLDR%20AND%20status%20%3D%20Done%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20%2246%22%20ORDER%20BY%20created%20ASC
[latest-delta-dtd]: https://www.unicode.org/cldr/charts/46/supplemental/dtd_deltas.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[latest-delta-dtd]: https://www.unicode.org/cldr/charts/46/supplemental/dtd_deltas.html)
[latest-delta-dtd]: https://www.unicode.org/cldr/charts/latest/supplemental/dtd_deltas.html

[dev-ldml]: https://www.unicode.org/reports/tr35/proposed.html
[dev-tickets]: https://unicode-org.atlassian.net/issues/?jql=project%20%3D%20CLDR%20AND%20status%20%3D%20Done%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20%2246%22%20ORDER%20BY%20created%20ASC)
[main]: https://github.com/unicode-org/cldr.git)
[dev-delta-dtd]: (https://www.unicode.org/cldr/charts/dev/supplemental/dtd_deltas.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[dev-delta-dtd]: (https://www.unicode.org/cldr/charts/dev/supplemental/dtd_deltas.html)
[dev-delta-dtd]: https://www.unicode.org/cldr/charts/dev/supplemental/dtd_deltas.html

[latest-delta-dtd]: https://www.unicode.org/cldr/charts/46/supplemental/dtd_deltas.html)

<!-- Dev release -->
[dev-version]: /index/downloads/dev)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few other cases where there was an extra trailing ")". Probably want to do a search on the page, then check the highlighted ones after line 200ish.

@macchiati
Copy link
Member

Here is the result of the validator, after deleting all the robot exclusions.

https://docs.google.com/document/d/1zEeXRqrOGHr6MtkeK7CZ19QAgMl3WwF3Gzo5Xq4jVgw/edit?tab=t.0

It looks like there are about 15 broken links, and then a few redirects (which are optional)

@AEApple AEApple requested review from macchiati and srl295 March 13, 2025 03:05
@github-actions
Copy link

✨ deployed to https://c71f56aa.cldr.pages.dev

@AEApple
Copy link
Contributor Author

AEApple commented Mar 13, 2025

I think I will fix the link issues which are unrelated in CLDR-18405

[Charts36]: https://www.unicode.org/cldr/charts/36/
[LDML36]: https://www.unicode.org/reports/tr35/tr35-57/tr35.html
[Δ36]: https://unicode-org.atlassian.net/issues/?jql=project%20%3D%20CLDR%20AND%20status%20%3D%20Done%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20%2236%22%20ORDER%20BY%20created%20ASC)
[Δ36]: https://unicode-org.atlassian.net/issues/?jql=project%20%3D%20CLDR%20AND%20status%20%3D%20Done%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20%2236%22%20ORDER%20BY%20created%20ASC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could maybe just make a redirect for this somewhere…

@AEApple AEApple dismissed macchiati’s stale review March 13, 2025 18:14

Made requested changes

@AEApple AEApple closed this Mar 13, 2025
@AEApple AEApple reopened this Mar 13, 2025
@github-actions
Copy link

✨ deployed to https://5c792a4d.cldr.pages.dev

@AEApple AEApple merged commit 7c9ce29 into main Mar 13, 2025
22 checks passed
@AEApple AEApple deleted the AEApple-CLDR-18400 branch March 13, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Site Update Updates docs/site

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants