-
Notifications
You must be signed in to change notification settings - Fork 419
CLDR-18400 Make downloads table easier to edit #4480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✨ deployed to https://44521519.cldr.pages.dev |
|
@srl295 - Is this along the lines of what you are thinking? If so I'll fix the error and update the rest of the table. |
srl295
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly seems more manageable!
Okay, I'll update the rest then. |
CLDR-18400 Update the links for the remaining versions. Fix visible errors in formatting.
|
✨ deployed to https://9aaa9b29.cldr.pages.dev |
CLDR-18400 Fix more table formatting errors
|
✨ deployed to https://bf21ad6d.cldr.pages.dev |
|
Out of curiosity I clicked on the "please see This Page for how to fix" link and got a 404 error (trying to go to https://cldr.unicode.org/development/main-rename). |
Can you file a ticket? |
|
@AEApple issue created: https://unicode-org.atlassian.net/browse/CLDR-18405 |
|
@macchiati - Try out the table in the preview. I just formatted the links at the bottom (which are not visible on the site) so anyone can read them easily. I can add a markdown comment to explain how to update the table if that would be helpful? I had been planning to put it on a different page. |
|
All works great, with a couple of exceptions. Looks like extra parens. latest-delta-dtd) Also, for latest we should use: And for dev we should use That way we never have to change those (and the dev one was really bad). |
macchiati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two link changes, OW ok. I'm also running the w3 validator on the generated page, and will post when finished.
docs/site/index/downloads.md
Outdated
| [latest-charts]: https://www.unicode.org/cldr/charts/46/index.html | ||
| [latest-ldml]: https://www.unicode.org/reports/tr35/ | ||
| [latest-tickets]: https://unicode-org.atlassian.net/issues/?jql=project%20%3D%20CLDR%20AND%20status%20%3D%20Done%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20%2246%22%20ORDER%20BY%20created%20ASC | ||
| [latest-delta-dtd]: https://www.unicode.org/cldr/charts/46/supplemental/dtd_deltas.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [latest-delta-dtd]: https://www.unicode.org/cldr/charts/46/supplemental/dtd_deltas.html) | |
| [latest-delta-dtd]: https://www.unicode.org/cldr/charts/latest/supplemental/dtd_deltas.html |
docs/site/index/downloads.md
Outdated
| [dev-ldml]: https://www.unicode.org/reports/tr35/proposed.html | ||
| [dev-tickets]: https://unicode-org.atlassian.net/issues/?jql=project%20%3D%20CLDR%20AND%20status%20%3D%20Done%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20%2246%22%20ORDER%20BY%20created%20ASC) | ||
| [main]: https://github.com/unicode-org/cldr.git) | ||
| [dev-delta-dtd]: (https://www.unicode.org/cldr/charts/dev/supplemental/dtd_deltas.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [dev-delta-dtd]: (https://www.unicode.org/cldr/charts/dev/supplemental/dtd_deltas.html) | |
| [dev-delta-dtd]: https://www.unicode.org/cldr/charts/dev/supplemental/dtd_deltas.html |
docs/site/index/downloads.md
Outdated
| [latest-delta-dtd]: https://www.unicode.org/cldr/charts/46/supplemental/dtd_deltas.html) | ||
|
|
||
| <!-- Dev release --> | ||
| [dev-version]: /index/downloads/dev) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few other cases where there was an extra trailing ")". Probably want to do a search on the page, then check the highlighted ones after line 200ish.
|
Here is the result of the validator, after deleting all the robot exclusions. https://docs.google.com/document/d/1zEeXRqrOGHr6MtkeK7CZ19QAgMl3WwF3Gzo5Xq4jVgw/edit?tab=t.0 It looks like there are about 15 broken links, and then a few redirects (which are optional) |
|
✨ deployed to https://c71f56aa.cldr.pages.dev |
|
I think I will fix the link issues which are unrelated in CLDR-18405 |
| [Charts36]: https://www.unicode.org/cldr/charts/36/ | ||
| [LDML36]: https://www.unicode.org/reports/tr35/tr35-57/tr35.html | ||
| [Δ36]: https://unicode-org.atlassian.net/issues/?jql=project%20%3D%20CLDR%20AND%20status%20%3D%20Done%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20%2236%22%20ORDER%20BY%20created%20ASC) | ||
| [Δ36]: https://unicode-org.atlassian.net/issues/?jql=project%20%3D%20CLDR%20AND%20status%20%3D%20Done%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%20%2236%22%20ORDER%20BY%20created%20ASC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could maybe just make a redirect for this somewhere…
|
✨ deployed to https://5c792a4d.cldr.pages.dev |
CLDR-18400
ALLOW_MANY_COMMITS=true