-
Notifications
You must be signed in to change notification settings - Fork 419
CLDR-18960 Add README.md files in common/* directories #5213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
-Replace some old _readme.txt with new README.md -Revise getAvailableIds() in CLDRTransforms.java to use only files with .xml extension; all files in common/transforms (CLDRTransforms.TRANSFORM_DIR) have the .xml extension, with the exception of the newly added README.md
| The UTS 35 LDML spec for datetime formatting will be updated in CLDR v48 to specify | ||
| that the default value for dateTimeFormatType will be "atTime". | ||
| The UTS 35 LDML spec for datetime formatting was updated in CLDR v48 to specify | ||
| that the default value for dateTimeFormatType is "atTime". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the change from "will be" to "was/is" since CLDR v48 has been released
srl295
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM plus suggestion
common/supplemental-temp/README.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| # CLDR `common/supplemental-temp` directory | |||
|
|
|||
| This directory contains an XML data file. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This directory contains an XML data file. | |
| This directory contains an XML data file used for testing. See [CLDR-15548](https://unicode-org.atlassian.net/browse/CLDR-15548) |
I just revised common/supplemental-temp/README.md as you suggested |
-Replace some old _readme.txt with new README.md
-Revise getAvailableIds() in CLDRTransforms.java to use only files with .xml extension; all files in common/transforms (CLDRTransforms.TRANSFORM_DIR) have the .xml extension, with the exception of the newly added README.md
CLDR-18960
ALLOW_MANY_COMMITS=true