Skip to content

Conversation

@sffc
Copy link
Member

@sffc sffc commented Dec 17, 2025

CLDR-17223

  • This PR completes the ticket.

NOTE: The CLDR implementation of locale display names needs to be updated with the new algorithm.

ALLOW_MANY_COMMITS=true

@sffc
Copy link
Member Author

sffc commented Dec 17, 2025

Do I need to add this to any of the following files where I find moreInformation referenced:

  • TestCoverageLevel.txt
  • missingOk.txt
  • prettyPath.txt
  • PathHeader.txt
  • PathDescriptions.md
  • IdToPath.java
  • ExampleDependencies.java
  • TestXPathTable.java

Also, about this test failure:

Error:  (TestExampleGenerator.java:327)  Error: No example:	<[>	"//ldml/characters/nestedBracketReplacement[@source=\"([^\"]*+)\"]",

I want this to not appear in survey tool, because it's easy to get wrong and it hardly ever changes. How should I do this? Should I add it to TestExampleGenerator::DELIBERATE_EXCLUDED_EXAMPLES like moreInformation is?

@sffc sffc requested a review from macchiati December 17, 2025 02:23
@sffc sffc marked this pull request as ready for review December 17, 2025 02:23
@conradarcturus
Copy link
Contributor

I was worried about not every language using parentheses (thereby a substitution could fail) but parentheses are pretty universal for localePattern https://www.unicode.org/cldr/charts/48/by_type/locale_display_names.locale_name_patterns.html#4c3249dbb329101c
Screenshot 2025-12-19 at 11 36 43

Can you test out the algorithm that would implement this on RTL locales? I want to make sure it doesn't cause problems.

Naming-wise, I like "innerBracket" (a bracket that is in a bracket) over "nestedBracketReplacement", but I defer to you.

Per usual, that's my 2 cents but I am happy to follow your lead. I'm deferring the accept to someone who is a more frequent Design group member.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants