Skip to content

Conversation

@xadxura
Copy link
Contributor

@xadxura xadxura commented Dec 27, 2025

CLDR-19169

  • [TRUE] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

These keyboard updates implement refinements for new LDML layouts for Sanskrit, Tibetan, and Gandhari including introducing backspace transforms and better use of set/uset.

@xadxura xadxura requested review from a team, mcdurdin and srl295 December 27, 2025 03:27
@xadxura xadxura self-assigned this Dec 27, 2025
@miloush
Copy link
Contributor

miloush commented Dec 27, 2025

We should probably have some guidance/policy on when to use codepoints (possibly with comments) and when to use characters themselves, these are difficult to review just in code.

@srl295
Copy link
Member

srl295 commented Dec 27, 2025

We should probably have some guidance/policy on when to use codepoints (possibly with comments) and when to use characters themselves, these are difficult to review just in code.

As usual, it depends on fonts, layout engines, RTL status, etc as to which is easier.

Tool wise, we could have something like cldrmodify which automatically enforces such a policy.

The simplest policy is of course to leave it to author's discretion.

<key id="K" output="\u{10A11}\m{A}" />
<key id="q" output="\u{10A11}\m{A}" />
<key id="Q" output="\u{10A11}\m{A}" />
<key id="Q" output="\u{10A11}\m{A}" /> <!--intentional duplicate -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps something such as "q and Q produce the same output"?

For that matter, why not just use the same key in two spots in the layout?

<layers formId="us">
<layer modifiers="none">
<row keys="grave 1 2 3 4 5 6 7 8 9 0 barabove equal"/>
<row keys="q w e r t y u i o p open-square close-square backslash"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have Q etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants