Fix Cmd+V paste not working in GitHub sign-in WebView#17
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix paste functionality on sign in page
Fix Cmd+V paste not working in GitHub sign-in WebView
Mar 1, 2026
Contributor
|
@copilot rebase |
Contributor
Author
Rebasing requires a force push, which isn't available in this environment. Could you rebase the branch manually, or merge the latest main into this branch? The code change itself is a single-file, non-conflicting addition so it should apply cleanly. |
2cb6f3a to
8e87e13
Compare
8e87e13 to
8ff7eb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WKWebViewon macOS silently consumes keyboard equivalents (Cmd+V, etc.) instead of forwarding them through the AppKit responder chain to web content. Right-click paste worked because it goes through a separate context menu path.Changes
GitHubWebAuthClient.swift: Introduces a privateEditableWebView: WKWebViewsubclass that overridesperformKeyEquivalent(with:)to dispatch editing shortcuts viaNSApp.sendAction:showLoginWindow()now instantiatesEditableWebViewinstead of plainWKWebView. All other behaviour is unchanged.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.