fix: Remove certificate pinning and simplify session handling#24
Merged
fix: Remove certificate pinning and simplify session handling#24
Conversation
Contributor
lazzurs
commented
Mar 2, 2026
lazzurs
commented
- Delete custom certificate pinning logic from CopilotSessionAPI.swift
- Use standard URLSession with default server trust validation
- Update GitHubSessionDelegate to only perform basic trust checks
- Simplify GitHubWebAuthClient to use nonPersistent WKWebView session
- Restrict WebKit navigation to GitHub domains only
- Remove unused cookie clearing and retry logic in WebAuth flow
- Improve comments and debug logging for authentication steps
- Delete custom certificate pinning logic from CopilotSessionAPI.swift - Use standard URLSession with default server trust validation - Update GitHubSessionDelegate to only perform basic trust checks - Simplify GitHubWebAuthClient to use nonPersistent WKWebView session - Restrict WebKit navigation to GitHub domains only - Remove unused cookie clearing and retry logic in WebAuth flow - Improve comments and debug logging for authentication steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.